Closed
Bug 1091058
Opened 10 years ago
Closed 10 years ago
buggy rendering of text-decoration lines in vertical writing
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
The work in bug 1074735 to support text decoration lines in vertical writing mode was incomplete; it works for simple cases, but with more complex examples the lines end up misplaced (or missing). See attached testcase, where all the text in all three <div>s should be underlined.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8513604 -
Flags: review?(smontagu)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Here's the testcase in reftest form.
Attachment #8514152 -
Flags: review?(smontagu)
Comment 3•10 years ago
|
||
Comment on attachment 8513604 [details] [diff] [review]
Fix positioning of text-decoration lines in vertical writing mode.
Review of attachment 8513604 [details] [diff] [review]:
-----------------------------------------------------------------
looks good
Attachment #8513604 -
Flags: review?(smontagu) → review+
Updated•10 years ago
|
Attachment #8514152 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ec811674d95
https://hg.mozilla.org/integration/mozilla-inbound/rev/aadd7fffaa99
Target Milestone: --- → mozilla36
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6ec811674d95
https://hg.mozilla.org/mozilla-central/rev/aadd7fffaa99
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•