Closed
Bug 1091484
Opened 10 years ago
Closed 10 years ago
TEST-UNEXPECTED-FAIL | null | notification tests swipe up should hide the toast
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S9 (21Nov)
People
(Reporter: daleharvey, Assigned: apastor)
Details
(Keywords: intermittent-failure, Whiteboard: [systemsfe])
Attachments
(2 files, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
This is the primary cause of our failures right now, I havent been able to reproduce locally, a waitFor may help but I would rather have someone who is familiar / responsible for that code to check it out, suggest disabling in the mean time
Reporter | ||
Comment 3•10 years ago
|
||
Alberto it looks like you have touched notifications a bunch recently, have you got any ideas?
Flags: needinfo?(apastor)
Reporter | ||
Comment 4•10 years ago
|
||
Attachment #8514244 -
Flags: review?(kgrandon)
Attachment #8514244 -
Flags: review?(etienne)
Attachment #8514244 -
Flags: review?(alive)
Assignee | ||
Comment 5•10 years ago
|
||
Not sure, as is hard to repro locally, but I think I have an idea of what is causing this. Taking.
Assignee: nobody → apastor
Flags: needinfo?(apastor)
Comment 6•10 years ago
|
||
Comment on attachment 8514244 [details]
Disable intermittent test
I won't review-, but I'll leave a F- because I think we should disable tests in the TBPL-manifest file from here on out.
Attachment #8514244 -
Flags: review?(kgrandon) → feedback-
Reporter | ||
Comment 7•10 years ago
|
||
The tbpl manifest can only have us disable the entire test file though, not individual tests, I also find it more confusing that we cant check the code to see what test is disabled why and have to cross reference failing tests with the test code and the manifest
I think tbpl manifest can go now that we dont support travis, but that aside in the case of disabling a single test using skip seems far more approriate than disabling all the tests
Comment 8•10 years ago
|
||
Disabling in the manifest makes the current disabled bugs much easier to digest/triage. I think it will also raise the urgency of re-enabling the test. If disabling multiple tests in a file is a problem, then I think there are too many tests in that file to begin with.
The new recommended practice is one or very few tests per file, in order to best take advantage of chunking.
Updated•10 years ago
|
Keywords: intermittent-failure
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8514244 [details]
Disable intermittent test
Clearing review, Alberto is looking at this, agreed with kevin on vidyo that if this isnt fixed by end of day, will disable via tbpl manifest
Attachment #8514244 -
Flags: review?(etienne)
Attachment #8514244 -
Flags: review?(alive)
Assignee | ||
Comment 10•10 years ago
|
||
Can't see anymore this error on the reports. About 50% failed because of [1] thought:
[1] command timed out:
1800 seconds without output running ['/tools/buildbot/bin/python', 'scripts/scripts/gaia_integration.py', '--cfg', 'b2g/gaia_integration_config.py', '--this-chunk', '3', '--total-chunks', '4', '-c', 'b2g/gaia_try.py', '-c', u'http://hg.mozilla.org/integration/gaia-try/raw-file/7c3dfdaf9b33d5726a50dd535f47d67716f1ef17/linux64.json', '--download-symbols', 'ondemand'], attempting to kill
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7c3dfdaf9b33
What do you think?
Flags: needinfo?(dale)
Comment 11•10 years ago
|
||
Fly-by-note: going to "0" might not be enough depending on where the drag starts, we might want to go -30px to be sure there's nothing left to transition of screen.
Reporter | ||
Comment 12•10 years ago
|
||
I triggered it another 9 times to be certain but looks good by me, those failures are unrelated
Flags: needinfo?(dale)
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8514923 -
Flags: review?(etienne)
Updated•10 years ago
|
Attachment #8514923 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 14•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
Reporter | ||
Comment 15•10 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 16•10 years ago
|
||
Updated•10 years ago
|
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
Assignee | ||
Comment 17•10 years ago
|
||
Seems pretty stable now. What do you think?
Attachment #8514923 -
Attachment is obsolete: true
Attachment #8529773 -
Flags: review?(dale)
Reporter | ||
Comment 18•10 years ago
|
||
Comment on attachment 8529773 [details]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26529
Sorry for the delay, I was on PTO + travelling, but this is looking good cheers
Attachment #8529773 -
Flags: review?(dale) → review+
Assignee | ||
Comment 19•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•