Closed Bug 109152 Opened 23 years ago Closed 15 years ago

Parser hands the sink attributes with no name! [@ HTMLContentSink::AddAttributes][@ HTMLAttributesImpl::SetAttributeName]

Categories

(Core :: DOM: HTML Parser, defect, P4)

x86
All
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: harishd, Unassigned)

References

()

Details

(Whiteboard: [fixed by the HTML5 parser])

spin off from bug 106527.
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla0.9.9
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: mozilla0.9.9 → Future
So why exactly is this a problem? That is, how _should_ the parser tokenize something like: <a ="foo"> ?
Hrm. So apparently my current fix in bug 261503 is going to break this case (the attribute is no longer created). But I'm not sure what we *should* do. I've seen bugs both mailnews and here that nobody likes these attributes (they cause crashes). I assume we'd violate some spec. by removing these nameless attributes? Note: the fix against my patch to allow these attributes is trivially easy.
I think simply dropping these nameless attributes is fine, especially since that's what the sink does anyway, no?
Seems reasonable to me.
Well, these unnamed attributes are still visible in the DOM inspector, but since everybody seems to think that we can drop them, I'd rather do that. I'll leave this bug open until the patch for bug 261503 is actually checked in.
Depends on: 261503
hmm... glazou, would you be ok with just dropping these from the DOM?
(In reply to comment #7) > hmm... glazou, would you be ok with just dropping these from the DOM? I see no reason why I would not be ok :-) This is a big markup error after all. Could the parser fire a warning somewhere ? Could be useful to authors.
Assignee: harishd → nobody
Status: ASSIGNED → NEW
QA Contact: moied → parser
Fixed when HTML5 parser enabled. (In the sense that stuff happens per spec.)
Please set the dependency on the bug on enabling it?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by the HTML5 parser]
You need to log in before you can comment on or make changes to this bug.