Stephen P. Morse Reporter
	Description • 23 years ago

Open form-manager dialog (tasks->privacy->form-manager->view-stored-data

All the field widths have been greatly reduced so as to be unusable in many 
cases.  For example, select the phone-numbers panel and you'll see feilds that 
are less than one character wide.

Blake, is this another fallout of bug 108762?

	Stephen P. Morse Reporter
	Comment 1 • 23 years ago

This is interesting.  Enter some data into these shrunken fields, then select 
another field and all the fields get bigger!  Of course that doesn't apply to 
the phone-number fields -- they're so small that you can't enter anything in 
there in the first place.

	Stephen P. Morse Reporter
	Comment 2 • 23 years ago

*** Bug 108676 has been marked as a duplicate of this bug. ***

	Stephen P. Morse Reporter
	Comment 3 • 23 years ago

Wait -- it's worse than just shrunken fields.  These widgets are supposed to be 
editable menulists but they no longer look like lists -- they look like just 
fields.

cc'ing cmanske who also has editable menulists somewhere.

	Stephen P. Morse Reporter
	Comment 4 • 23 years ago

The shrunken size is being caused by the following change that was made by blake 
for the xul cleanup (bug 108762.

-  <groupbox class="tabpanel" autostretch="never">
+  <groupbox align="start">

This occurs in the .xul files in extensions/wallet/editor.

I still don't know what is causing the loss of editable menulists.

	Charles Manske
	Comment 5 • 23 years ago

Note that the default "orient" used to be "horizontal", but is now "vertical" for
groupboxes. Try adding 
orient="horizontal" 
to your groupbox tag.
The editable menulists should still work fine -- maybe they are just getting 
chopped off.

	Stephen P. Morse Reporter
	Comment 6 • 23 years ago

orient=horizontal makes on difference.

	Charles Manske
	Comment 7 • 23 years ago

Steve: Which dialog is this?

	Stephen P. Morse Reporter
	Comment 8 • 23 years ago

All of them.

As mentioned in the bug description, open the dialog with:

   tasks->privacy->form-manager->view-stored-data

The initial panel that is open is the name panel and it has the problem.  Select 
any other panel in the list at the left.  They all have the problem.

	Stephen P. Morse Reporter
	Comment 9 • 23 years ago

Simplified testcase.  Note that the menulist outside the group box displays full 
width.  The one inside the groupbox is shrunken.  Removing the align="start" 
from the groupbox makes both menulists be full width.

But neither of these menulists display as menulist.  They look like textfields 
instead.

<?xml version="1.0"?> 
<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
<page xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

  <menulist editable="true">
    <menupopup>
      <menuitem label=""/>
    </menupopup>
  </menulist>

  <groupbox align="start">
    <menulist editable="true">
      <menupopup>
        <menuitem label=""/>
      </menupopup>
    </menulist>
  </groupbox>
</page>

	Stephen P. Morse Reporter
	Comment 10 • 23 years ago

And removing the editable="true" from the menulists makes them once again look 
like menulists.  But of course they won't be editable.

	Charles Manske
	Comment 11 • 23 years ago

Oh my god! Your right, they've killed editable menulists! They aren't working in
all Composer instances as well.

	Stephen P. Morse Reporter
	Comment 12 • 23 years ago

Raising to critical based on cmanske's discovery.

	Charles Manske
	Comment 13 • 23 years ago

Bug filed for editable menulist problem.
Keeping this bug for any other changes needed other than that issue.

	Charles Manske
	Comment 14 • 23 years ago

Stomped on your "critical" change. Marked bug 109190 "critical" instead

	Stephen P. Morse Reporter
	Comment 15 • 23 years ago

OK, will keep this bug just for the shrunken fields in form-manager the other 
new bug that you opened for the loss-of-menulist problem.  It's now clear that 
they are two separate issues.

	Blake Ross
	Comment 16 • 23 years ago

I don't think I caused this. This was working in nightlies for a few days after
I landed.

	Blake Ross
	Comment 17 • 23 years ago

I mean, I don't think I caused the critical bug, 109163.  I'll look into this.

	Stephen P. Morse Reporter
	Comment 18 • 23 years ago

So the fix here is to remove the align="start" that was added as part of the 
overall xul fixup (bug 108762).

One more piece of fallout from the overall xul fixup is that urlspecific panel 
no longer opens -- gives a syntax error.  I was about to fix that as well as 
part of this patch (/window -> /page) but I just noticed that timeless caught 
that and checked in a fix a few minutes ago.

	Stephen P. Morse Reporter
	Comment 20 • 23 years ago

cc'ing blake and alecf for reviews

	Blake Ross
	Comment 21 • 23 years ago

Well, they had align="start" because that's the equivalent of autostretch="never
that used to be there.   I don't see why this would behave any different.

	Blake Ross
	Comment 22 • 23 years ago

Comment on attachment 57174 [details] [diff] [review]
removing align="start"

sr=blake
(btw, timeless checked in the fix 12 hrs ago)

	Stephen P. Morse Reporter
	Comment 23 • 23 years ago

Sorry, I looked at the time of timeless' other checkin when I said a few moments 
ago.  Actually he checked in this fix 6 hours ago.

	jag (Peter Annema)
	Comment 24 • 23 years ago

Comment on attachment 57174 [details] [diff] [review]
removing align="start"

r=jag

	Asa Dotzler [:asa]
	Comment 25 • 23 years ago

a=asa (on behalf of drivers) for checkin to 0.9.6

	Stephen P. Morse Reporter
	Comment 26 • 23 years ago

fix checked in

	Tracy Walker [:tracy]
	Comment 27 • 23 years ago

verified...this hasn't been a problem for quite some time.