Closed Bug 109164 Opened 23 years ago Closed 23 years ago

Active Accessibility: state change events for XUL checkboxes

Categories

(SeaMonkey :: General, defect, P3)

x86
Windows 2000
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla0.9.7

People

(Reporter: aaronlev, Assigned: aaronlev)

References

Details

(Keywords: access)

Attachments

(1 file)

Right now our state change events work only for HTML radio buttons and checkboxes. We need to extend support to XUL.
Status: NEW → ASSIGNED
Keywords: access, fcc508
Priority: -- → P3
Target Milestone: --- → mozilla0.9.7
Changing summary: John Gaunt is going to implement radio button state changes as part of his radio button support.
Summary: Active Accessibility: state change events for XUL radio buttons and checkboxes → Active Accessibility: state change events for XUL checkboxes
Attached patch Tested -- works (deleted) — Splinter Review
Whiteboard: seeking r=, sr=
Blocks: 82207
Comment on attachment 57130 [details] [diff] [review] Tested -- works r=jgaunt
Attachment #57130 - Flags: review+
We don't need to fire a custom event from JS whenever the checked property changes. It's also legitimate to change the checked property using an attribute (rather than using the property), and your code will need to handle that case as well. A DOMAttributeChanged mutation event covers this case. You can listen for the checked attribute changing on checkboxes.
What kind of performance/bloat hit will DOMAttrModified cause, if I'm listening to it on a document node. I know it sets a flag that causes Mozilla to do extra work that it normally doesn't need to. That's why I'm using those custom events, to ensure the same performance when accessibility is turned on.
Whiteboard: seeking r=, sr= → seeking sr=
Change 'MutationEvents' to 'Events'. This isn't a mutation event that you're making here. With that change, sr=hyatt
-> fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: seeking sr=
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: