Closed
Bug 109164
Opened 23 years ago
Closed 23 years ago
Active Accessibility: state change events for XUL checkboxes
Categories
(SeaMonkey :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: aaronlev, Assigned: aaronlev)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
Right now our state change events work only for HTML radio buttons and checkboxes.
We need to extend support to XUL.
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 1•23 years ago
|
||
Changing summary: John Gaunt is going to implement radio button state changes as
part of his radio button support.
Summary: Active Accessibility: state change events for XUL radio buttons and checkboxes → Active Accessibility: state change events for XUL checkboxes
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Whiteboard: seeking r=, sr=
Comment 3•23 years ago
|
||
Comment on attachment 57130 [details] [diff] [review]
Tested -- works
r=jgaunt
Attachment #57130 -
Flags: review+
Comment 4•23 years ago
|
||
We don't need to fire a custom event from JS whenever the checked property
changes. It's also legitimate to change the checked property using an attribute
(rather than using the property), and your code will need to handle that case as
well.
A DOMAttributeChanged mutation event covers this case. You can listen for the
checked attribute changing on checkboxes.
Assignee | ||
Comment 5•23 years ago
|
||
What kind of performance/bloat hit will DOMAttrModified cause, if I'm listening
to it on a document node. I know it sets a flag that causes Mozilla to do extra
work that it normally doesn't need to.
That's why I'm using those custom events, to ensure the same performance when
accessibility is turned on.
Assignee | ||
Updated•23 years ago
|
Whiteboard: seeking r=, sr= → seeking sr=
Comment 6•23 years ago
|
||
Change 'MutationEvents' to 'Events'. This isn't a mutation event that you're
making here.
With that change, sr=hyatt
Assignee | ||
Comment 7•23 years ago
|
||
-> fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: seeking sr=
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•