Closed
Bug 1091693
Opened 10 years ago
Closed 10 years ago
history tests folder should be one level higher
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: mak, Assigned: awake, Mentored)
References
Details
(Whiteboard: [lang=js][good first bug])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
the history folder for history.remove test has been created under unit/, it should have been created under tests/ like all of the other folders (bookmarks, autocomplete, ...)
I should have noticed this detail in the review.
Comment 1•10 years ago
|
||
Basically, the idea is to move http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history/unit/. A few moz.build files will need to be updated.
Mentor: dteller
Whiteboard: [lang=js][good first bug]
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #1)
> Basically, the idea is to move
> http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> tests/unit/history to toolkit/components/places/tests/history/unit/
nope, we should move toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history
Assignee | ||
Comment 3•10 years ago
|
||
Hi, I'd like to work on this as my first bug. Could someone assign this bug to me?
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8523492 -
Flags: review?(dteller)
Updated•10 years ago
|
Assignee: nobody → bugzillafx
Comment 5•10 years ago
|
||
Comment on attachment 8523492 [details] [diff] [review]
bug1091693.diff
Review of attachment 8523492 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me.
Let's see the results on Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f0ea42cfdeee
Attachment #8523492 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Updated•10 years ago
|
Attachment #8523492 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8525259 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][good first bug][fixed-in-fx-team] → [lang=js][good first bug]
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•