Closed
Bug 1091917
Opened 10 years ago
Closed 9 years ago
Enable leak logging for content processes on Windows
Categories
(Testing :: General, defect, P1)
Testing
General
Tracking
(e10s+, firefox47 fixed)
RESOLVED
FIXED
mozilla47
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
1. Fix bug 1073310.
2. Remove the |#if defined(XP_WIN)| block in |ShutdownXPCOM| that calls exit(0).
3. Remove the |if mozinfo.isWin: options.ignoreMissingLeaks.append["tab"]| block I'm going to add to mochitest_options.py in bug 1083897 so we require leak logs for content processes on Windows.
Assignee | ||
Comment 2•10 years ago
|
||
This is probably the important remaining piece of bug 1051230.
tracking-e10s:
--- → ?
Updated•10 years ago
|
Updated•10 years ago
|
Assignee | ||
Comment 3•9 years ago
|
||
I think there are three remaining pieces of this:
1. bug 1193861 - Ensure child processes are recorded on Windows in the pidlog, so the test harness can tell if a process failed to create a log.
2. bug 1219369 - We're not actually recording leak logs on Windows 7 m-c due to sandboxing.
3. bug 1242119 - We're not getting leak logs on WinXP due to an early exit(0).
Fixing this bug will then consist of removing this chunk from mochitest_options.py:
if mozinfo.isWin:
options.ignoreMissingLeaks.append("tab")
Assignee | ||
Comment 4•9 years ago
|
||
Currently, leakcheck ignores failures to produce a leak log on Windows for tab processes, because we don't ever generate a log for them. Once the blocking bugs are fixed, we will, so we should start enforcing that we actually doing leak checking.
Try run with patches from the blocking bugs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5
I'll need to do a WinXP and Win8 try run to make sure it works on those platforms, but it looks like Win7 works.
Attachment #8715318 -
Flags: review?(cmanchester)
Assignee | ||
Updated•9 years ago
|
Attachment #8514658 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8715318 -
Flags: review?(cmanchester) → review+
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•9 years ago
|
||
Still green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb639445f575
I'll land this when the tree reopens.
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•