Closed
Bug 1092001
Opened 10 years ago
Closed 10 years ago
Fix warnings in dom/tv and mark as FAIL_ON_WARNINGS
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This patch fixes the following clang warnings recently introduced in bug 998872 and marks the dom/tv directory as FAIL_ON_WARNINGS:
> dom/tv/FakeTVService.cpp:229:397: error: deleting object of polymorphic class type 'mozilla::dom::EITBroadcastedCallback' which has non-virtual destructor might cause undefined behaviour [-Werror=delete-non-virtual-dtor]
> dom/tv/FakeTVService.cpp:258:393: error: deleting object of polymorphic class type 'mozilla::dom::ScanCompleteCallback' which has non-virtual destructor might cause undefined behaviour [-Werror=delete-non-virtual-dtor]
> dom/tv/TVListeners.cpp:15:1 [-Wdelete-non-virtual-dtor] delete called on 'mozilla::dom::TVSourceListener' that has virtual functions but non-virtual destructor
> dom/tv/TVProgram.h:74:8 [-Wunused-private-field] private field 'mIsInterrupting' is not used
Here's a green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=c8e3d4b360ec
Attachment #8514789 -
Flags: review?(ehsan.akhgari)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8514789 [details] [diff] [review]
fix-tv-warnings.patch
Review of attachment 8514789 [details] [diff] [review]:
-----------------------------------------------------------------
r=me sans the already fixed stuff.
::: dom/tv/TVListeners.h
@@ +14,5 @@
>
> namespace mozilla {
> namespace dom {
>
> +class TVSourceListener MOZ_FINAL : public nsITVSourceListener
I just fixed this on inbound. :-)
::: dom/tv/TVProgram.h
@@ -70,5 @@
> uint64_t mStartTime;
> uint64_t mDuration;
> nsString mDescription;
> nsString mRating;
> - bool mIsInterrupting;
This too.
Attachment #8514789 -
Flags: review?(ehsan.akhgari) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•