Closed
Bug 1092021
Opened 10 years ago
Closed 10 years ago
[Messages] Report panel visual refresh follow up for word truncate and l10n issue
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: steveck, Assigned: steveck)
References
Details
(Whiteboard: [sms-sprint-2.1S8])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1021608 +++
Some new issues after bug 1021608 landed, please see Bug 1021608 comment 43:
1: Warning console: Messages: Content JS WARN: mozL10n: A non-existing entity requested: report-status-not-applicable
2: Word in contact information field might truncate.
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Julien, here is the fixed for the issues you mentioned in report refresh, thanks for the reminder.
Attachment #8514803 -
Flags: review?(felash)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8514803 [details]
Link to github
Redirecting to oleg :)
Attachment #8514803 -
Flags: review?(felash) → review?(azasypkin)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8514803 [details]
Link to github
Looks good, just two questions at Github.
Thanks!
Attachment #8514803 -
Flags: review?(azasypkin) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8514803 [details]
Link to github
Hi Oleg, I refined the patch with your suggestion: For the another l10n properties, it's not related to this patch indeed, but I think we should address in the patch as well. And the selector is defiantly wrong, I fixed it for the report div right under the contact filed but without carrier info.
Attachment #8514803 -
Flags: review+ → review?(azasypkin)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8514803 [details]
Link to github
r=me, just two tiny nits, one of which is optional.
Thanks!
Attachment #8514803 -
Flags: review?(azasypkin) → review+
|
|
||
Updated•10 years ago
|
Whiteboard: [sms-sprint-2.1S8]
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks! I left some explanation on github.
In master: 7356d60a1fa0c7aef1c5682fbd47c65bd84dcea8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•