Jim Mathies [:jimm] Assignee
	Description • 10 years ago

str:

1) load the msn game (let flash load, ignore the install silverlight button)
2) once the game loads, try right-clicking for a context menu or clicking something in the game.

result: context menu is positioned incorrectly or no clicks delivered to app.

	Benjamin Smedberg
	Comment 1 • 10 years ago

http://zone.msn.com/gameplayer/gameplayer.aspx?game=bubbletown&instance=default

See bug 596451 part F for some historical context, as well as bug 547353.

	Jim Mathies [:jimm] Assignee
	Comment 2 • 9 years ago

this test case is windowed now.

	Jim Mathies [:jimm] Assignee
	Comment 4 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1478b996cce7

	Jim Mathies [:jimm] Assignee
	Comment 5 • 9 years ago

This patch fixes up the plugin quirks stuff which is breaking things in subtle ways, and it fixes GetNetscapeWindow which is currently broken in e10s. The latter can cause a perf hit since flash hammers us for this info. We cache this handle in PluginInstanceChild if it's valid, but if not, we go ever ipc to retrieve it.

The PBorwser change was just cosmetic, moving plugin related apis to a common area.

	Jim Mathies [:jimm] Assignee
	Comment 6 • 9 years ago

Had a good discussion with billm - he suggested removing the tab child shortcut and relying on the old code, with an update to the XP_WIN bits to use NS_NATIVE_SHAREABLE_WINDOW. This should work in e10s and in non-e10s (testing indicates this is the case) since we grab the handle from the root widget.

Note PuppetWidget supports NS_NATIVE_SHAREABLE_WINDOW, but doesn't support NS_NATIVE_WINDOW - hence the original failure here. Switching it wouldn't have helped, since win32's nsWindow didn't support NS_NATIVE_SHAREABLE_WINDOW properly until now.

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 7 • 9 years ago

Comment on attachment 8553341 [details] [diff] [review]
patch

Review of attachment 8553341 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks very much.

::: dom/plugins/ipc/PluginModuleChild.cpp
@@ +193,5 @@
>  PluginModuleChild::GetChrome()
>  {
> +    // A special PluginModuleChild instance that talks to the chrome
> +    // process during startup and shutdown. Use of this object's ipc
> +    // apis risk process hangs, be careful!

Perhaps be more specific: "Synchronous messages from or to this actor should be avoided because they may lead to hangs."

	Jim Mathies [:jimm] Assignee
	Comment 8 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d304dc8a9cbc

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6aa664922b85

	Phil Ringnalda (:philor)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6aa664922b85