A <listbox> can have multiple selections (sometimes? always?) It's not implemented yet - see bug 70858

to aaron per our discussion

-> back to jgaunt, since we have to wait for hewitt's fix on 70858

So far this is working everywhere except the doDefaultAction. That I can find anyway. I'm still doing some poking.

Comment on attachment 69703 [details] [diff] [review] XUL listbox acc support r=aaronl Nits: I take it that this patch fixes default actions for html selects as well? What other bugs does this fix? - // add ourself as a RadiobuttonStateChange listener (custom event fired in nsHTMLInputElement.cpp) Why remove this comment instead of editing it and keeping it in there? + // may have to register as a nsIDOMXULListener for this same string This comment is confusing. +// nsCOMPtr<nsIPresContext> presContext; +// GetPresContext(presContext); +// if (presContext) +// rv = content->HandleDOMEvent(presContext, &event, nsnull, NS_EVENT_FLAG_INIT ,&status); Do you want to remove commented out code? In nsXULListboxAccessible::GetSelectedChildren() I just noticed we have a superfluous return NS_OK; in the if statement right before the end.

The html select work got in by mistake, taken out fixed the comment about the radio button took out the extra return and removed the commented out code as it really doesn't apply

Comment on attachment 69752 [details] [diff] [review] cleaned up for r= nits sr=hewitt

checked in last night/this morning with great fireworks