We should support it using: ROLE_PAGETABLIST, ROLE_PAGETAB and ROLE_PROPERTYPAGE.

Spelling error: tabbroswer/editor Indentation error in nsXULTabAccessible::GetAccName oops? ... +NS_IMETHODIMP nsXULTabPanelsAccessible::GetAccName(nsAWritableString& _retval) +{ + return NS_OK; +} +NS_IMETHODIMP nsXULTabPanelAccessible::GetAccName(nsAWritableString& _retval) +{ + return NS_OK; +} + +/** focused, focusable, unavailable */ +NS_IMETHODIMP nsXULTabPanelAccessible::GetAccState(PRUint32 *_retval) +{ + return NS_OK; +} + If you want empty names, return NS_ERROR_NOT_IMPLEMENTED; If you want an empty state, make sure to set it with *_retval = 0; Remove printf(" - just got the tabPanels' mDOMNode"); Make sure this thing doesn't leak. When you set mDOMNode like that, which is a protected data member from above in the inheritence chain, it can cause a leak. I found that out once when I was trying to explictly set mParent in a similar manner. Fix extra semicolon return NS_OK;; Get rid of printf("creating nsXULTabBoxAccessible *********\n"); Why do you need +NS_IMETHODIMP nsXULTabBoxAccessible::GetAccChildCount(PRInt32 *_retval) +{ + *_retval = 2; + return NS_OK; +} I see that you originally planned on overriding GetFirstChild and GetLastChild. You still have those method declarations commented out in the .h file

I hardcoded the children because those are the only two and I was creating them by hand for awhile. But I'm leaving it in because it doesn't make any sense to thrash around the tree walker to find out there are only 2 kids if we know that in advance.

Comment on attachment 61342 [details] [diff] [review] aaron's fixes r=aaronl

Comment on attachment 61342 [details] [diff] [review] aaron's fixes sr=hewitt

checked in yesterday