Closed Bug 1092335 Opened 10 years ago Closed 10 years ago

Ditch our upgrade nag bar in favor of Tabzilla's

Categories

(support.mozilla.org :: Code Quality, task, P3)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2014Q4

People

(Reporter: mythmon, Assigned: rrosario)

References

Details

(Whiteboard: u=dev c=general p=1 s=2014.20)

Tabzilla just landed support for version nagging[1]. We should use it instead of ours so that we can not worry about UA parsing and ESR det tion(which tabzilla will get soon) and what the latest Firefox is (at least for version nags). I bet this will be pretty easy. The documentation for this [2] says we just have to add a data-attribute to the script tag we use for Tabzilla, and then we would need to remove all of our version notification code. Easy peasy. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=935719 [2] https://github.com/mozilla/bedrock/blob/master/docs/tabzilla.rst
This makes good sense!
Yes, let's do this!
Priority: -- → P3
Target Milestone: --- → 2014Q4
I love deleting code first thing on a Monday morning. Grabbing into current sprint.
Assignee: nobody → rrosario
Whiteboard: u=dev c=general p=1 s=2014.21 → u=dev c=general p=1 s=2014.20
deployed to prod.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #6) > deployed to prod. Nice! "That was easy!"
You need to log in before you can comment on or make changes to this bug.