A lot of the code in sdk/preferences/service is duplicated in resource://gre/modules/Preferences.jsm and since it is easier to use a jsm in a sdk module than vice versa we should do so.

Comment on attachment 8519004 [details] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1704 lgtm!

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/21795699924dcd1a7dbf9a977a247cc634a58905 Bug 1092882 - preferences/service should utilize Preferences.jsm https://github.com/mozilla/addon-sdk/commit/bced24ac402caf08633666f2f651ebc35c8002d0 Merge pull request #1704 from erikvold/1092882 Bug 1092882 - preferences/service should utilize Preferences.jsm r=@jsantell

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a31da7055d02aa268a644b0bfe6f3db1faa5e85a Bug 1092882 - bug fix: setting a pref to undefined now returns a slightly different, more specific error now a=erikvold https://github.com/mozilla/addon-sdk/commit/240f5de953bf4b09d9ef2497d4bc23bd49415b40 Merge pull request #1708 from erikvold/1092882 Bug 1092882 - preferences/service should utilize Preferences.jsm r=jsantell