Closed
Bug 1092893
Opened 10 years ago
Closed 10 years ago
[System2] Implement BluetoothCore
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: alive, Unassigned)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
BluetoothCore is responsible to load / launch all Bluetooth related modules.
|
||
Updated•10 years ago
|
|
|
||
Comment 1•10 years ago
|
||
move bluetooth related bootstraping code into bluetooth_core to fulfill system 2 structure
Attachment #8515845 -
Flags: review?(alive)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8515845 [details]
pull request redirect to github
r+ with nits - for stop I don't think you need a stop function right now. Replace stop with no-op or leave it unchanged.
Attachment #8515845 -
Flags: review?(alive) → review+
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8515845 [details]
pull request redirect to github
@alive thanks for quick review. I've addressed nits. The only thing unclear is I'm not sure what 'With BaseModule you could stub window.XXX before instantiate it' means in test file. Could you elaborate more about it?
Attachment #8515845 -
Flags: feedback?(alive)
|
|
Reporter | |
Comment 4•10 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #3)
> Comment on attachment 8515845 [details]
> pull request redirect to github
>
> @alive thanks for quick review. I've addressed nits. The only thing unclear
> is I'm not sure what 'With BaseModule you could stub window.XXX before
> instantiate it' means in test file. Could you elaborate more about it?
See https://github.com/alivedise/gaia/blob/bugzilla/1062819_pickup_rebased/mobile-connection-core/apps/system/test/unit/mobile_connection_core_test.js
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8515845 -
Flags: feedback?(alive) → feedback+
|
|
||
Comment 5•10 years ago
|
||
Still not get it now, but I could enhance it later since these file will be touched several times during BT v2 support progress.
landed https://github.com/mozilla-b2g/gaia/commit/398e4f1122708b3974a72ae72e6180a4780c2294
thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•