Closed Bug 1093090 Opened 10 years ago Closed 10 years ago

Edge gestures interrupt with list navigation UI

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wilsonpage, Assigned: etienne)

References

Details

(Whiteboard: ux-most-wanted-nov2014)

Attachments

(1 file)

(deleted), text/x-github-pull-request
kgrandon
: review+
wilsonpage
: feedback+
Details
Assignee: nobody → etienne
Adding to UX bug tracking.
QA Whiteboard: ux-most-wanted
Blocks: 1098041
Blocks: 994991
Whiteboard: ux-most-wanted-nov2014
Attached file Gaia PR (deleted) —
Hi Wilson, here's a new version of the detector based on the angle of the gesture, it looks pretty promising. I'd love it if you could give it a spin too, let me know! Cheers!
Attachment #8524615 - Flags: feedback?(wilsonpage)
Comment on attachment 8524615 [details] Gaia PR Ace! Seems much better :)
Attachment #8524615 - Flags: feedback?(wilsonpage) → feedback+
Comment on attachment 8524615 [details] Gaia PR Will retrigger a bunch the "vertical swipe" test but this is ready for review :)
Attachment #8524615 - Attachment description: WIP → Gaia PR
Attachment #8524615 - Flags: review?(kgrandon)
so much green :)
Comment on attachment 8524615 [details] Gaia PR Hey Etienne - Looks good, but I have a concern that we're regressing usability on higher display density devices. Which devices did you test with? When I tested on a nexus4 I noticed that I had a much harder time actually entering the edge gesture - my guess was that this was due to the higher display density, but I could be wrong. Basically with this patch I think that you have to be *extremely* accurate to enter an edge gesture, almost too accurate. Can we relax the angle some, or take into consideration devicePixelRatio?
Flags: needinfo?(etienne)
Attachment #8524615 - Flags: review?(kgrandon)
Comment on attachment 8524615 [details] Gaia PR As good as the horchata?
Flags: needinfo?(etienne)
Attachment #8524615 - Flags: review?(kgrandon)
Comment on attachment 8524615 [details] Gaia PR This is looking good to me, thanks! I would still prefer to use the alternate syntax for the angle check as I commented in github. Up to you if you want to update the code though.
Attachment #8524615 - Flags: review?(kgrandon) → review+
(In reply to Kevin Grandon :kgrandon from comment #8) > Comment on attachment 8524615 [details] > Gaia PR > > This is looking good to me, thanks! I would still prefer to use the > alternate syntax for the angle check as I commented in github. Yes it's much better :) https://github.com/mozilla-b2g/gaia/commit/a208afd47dd0f9633068ada61bc9829b5a2bed7a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: