Closed
Bug 1093198
Opened 10 years ago
Closed 10 years ago
WebIDE button looks odd in clicked state
Categories
(DevTools :: General, defect)
Tracking
(firefox35 verified, firefox36 verified)
VERIFIED
FIXED
Firefox 36
People
(Reporter: canuckistani, Assigned: paul)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
paul
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
If I hld down the button click on the webide button, it looks odd in the cicked state, un-like other buttons. Is this intentional?
Reporter | ||
Updated•10 years ago
|
Blocks: fx-dev-edition
Reporter | ||
Updated•10 years ago
|
Group: mozilla-employee-confidential
Assignee | ||
Comment 1•10 years ago
|
||
(In reply to Jeff Griffiths (:canuckistani) from comment #0) > Is this intentional? No.
Assignee: nobody → paul
Assignee | ||
Comment 2•10 years ago
|
||
Apparently, it's only osx non-retina.
Assignee | ||
Comment 3•10 years ago
|
||
I don't have a non-retina display. Can someone test for me?
Comment on attachment 8516104 [details] [diff] [review] v1 Review of attachment 8516104 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the issue on my non-retina display.
Attachment #8516104 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
(fixed the commit message)
Attachment #8516104 -
Attachment is obsolete: true
Attachment #8516118 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8516118 [details] [diff] [review] v1 (r=jryans) Approval Request Comment [Feature/regressing bug #]: dev-edition [User impact if declined]: wrong icon for webide widget [Describe test coverage new/current, TBPL]: none. [Risks and why]: very low. Just a css coordinate change [String/UUID change made/needed]: none.
Attachment #8516118 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/035fe2d2cd62
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
Attachment #8516118 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•10 years ago
|
||
Reproduced using Mac 10.9.5 non-retina on Nightly and DevEd 2014-11-03. Verified as fixed using today's builds.
Updated•10 years ago
|
Group: mozilla-employee-confidential
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•