Closed
Bug 1093506
Opened 10 years ago
Closed 10 years ago
[RIL] Should present the "number" for outgoing call in CLCC
Categories
(Firefox OS Graveyard :: Emulator, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: aknow, Assigned: aknow)
References
Details
Attachments
(2 files)
This cause the fail in marionette test, ex: test_temporary_clir.js
In the test case, we try to send the request "gsm cancel <number>". However, the number becomes empty because it is not shown in CLCC.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8516546 -
Flags: review?(htsai)
Comment 2•10 years ago
|
||
Comment on attachment 8516546 [details]
PR 118
Steal r? if you don't mind :)
Attachment #8516546 -
Flags: review?(htsai) → review?(echen)
Comment 3•10 years ago
|
||
(In reply to Szu-Yu Chen [:aknow] from comment #1)
> Created attachment 8516546 [details]
> PR 118
Please see my comments in github, thank you.
Comment 4•10 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> Comment on attachment 8516546 [details]
> PR 118
>
> Steal r? if you don't mind :)
No problem, thank you very much :P
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Szu-Yu Chen [:aknow] from comment #1)
> > Created attachment 8516546 [details]
> > PR 118
>
> Please see my comments in github, thank you.
Fixed. Thank you.
Comment 6•10 years ago
|
||
Comment on attachment 8516546 [details]
PR 118
Thank you.
Attachment #8516546 -
Flags: review?(echen) → review+
Comment 7•10 years ago
|
||
Try with qemu changes looks good: https://tbpl.mozilla.org/?tree=Try&rev=31e2718246fa \o/
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #7)
> Try with qemu changes looks good:
> https://tbpl.mozilla.org/?tree=Try&rev=31e2718246fa \o/
\o/
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
Comment 10•10 years ago
|
||
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
Hi Aknow,
Could you help provide a pull request to kk-branch? Thank you.
Flags: needinfo?(szchen)
Assignee | ||
Comment 13•10 years ago
|
||
Flags: needinfo?(szchen)
Attachment #8533581 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
checkin-needed for PR 122
It's the PR for kk branch
Keywords: checkin-needed
Comment 15•10 years ago
|
||
b2g-kitkat: https://github.com/mozilla-b2g/platform_external_qemu/commit/615f94d1fb5a75211485a81fcaa8baed7731bfb7
Keywords: checkin-needed
Updated•10 years ago
|
Blocks: emulator-kk
Updated•10 years ago
|
Blocks: emulator-l_taskcluster
Updated•10 years ago
|
No longer blocks: emulator-l_taskcluster
You need to log in
before you can comment on or make changes to this bug.
Description
•