Closed Bug 1093590 Opened 10 years ago Closed 10 years ago

Trim down site_config API when called with serializer=commonplace

Categories

(Marketplace Graveyard :: API, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-11-11

People

(Reporter: mat, Assigned: mat)

References

Details

When called with serializer=commonplace, the site_config API return waffle flags and switches. switches are returned in a simple list containing the names of the switches that are activated, but flags is returned as a dict with all the properties.

We don't need all those properties when serializer=commonplace, in fact we might not even need the flags at all in that case. 

It blocks bug 1093584 just because we need to figure out exactly what we should expose as data attributes in that bug.
Assignee: nobody → mpillard
Priority: -- → P3
Status: NEW → ASSIGNED
Fixed in https://github.com/mozilla/zamboni/commit/5fcc7e6847d72db44ff202f479b8a9d3bb555a44

QA:
- Verify that you can still log in with FxA when the corresponding waffle switch is enabled (wait 5 minutes after enabling the switch just in case, to account for caching)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-11-11
I could still log in using fxa today, but I'm not sure which waffle switch i must enabled.
Flags: needinfo?(mpillard)
It's working fine in production.
Status: RESOLVED → VERIFIED
Flags: needinfo?(mpillard)
You need to log in before you can comment on or make changes to this bug.