Closed Bug 1093608 Opened 10 years ago Closed 8 years ago

[DSDS] Add test to check which SIM was involved in the call on the call log

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file)

Gaia PR
(deleted), text/x-github-pull-request
drs
: review+
Details
Base user story: Bug 947131 - [DSDS]Call Log shows which SIM was involved in call 1. Receive a call on SIM 1 2. Make a call with SIM 2 3. Check call log
Assignee: nobody → jlorenzo
Blocks: 947131
QA Whiteboard: [fxosqa-auto-s3][fxosqa-auto-points=2]
QA Whiteboard: [fxosqa-auto-s3][fxosqa-auto-points=2] → [fxosqa-auto-s4][fxosqa-auto-points=2]
QA Whiteboard: [fxosqa-auto-s4][fxosqa-auto-points=2] → [fxosqa-auto-from-s3][fxosqa-auto-s4][fxosqa-auto-points=2]
Attached file Gaia PR (deleted) —
Regarding comment 0, I changed: > 1. Receive a call on SIM 2 > 2. Make a call with SIM 1 I'll ask for review once bug 1093583 lands.
No need to wait for bug 1093583 anymore.
Depends on: 1098279, 1098311, 1098317
No longer depends on: 1093583
Attachment #8520890 - Flags: review?(viorela.ioia)
Attachment #8520890 - Flags: review?(robert.chira)
Attachment #8520890 - Flags: review?(drs.bugzilla)
Comment on attachment 8520890 [details] Gaia PR Please address comment in the PR.
Attachment #8520890 - Flags: review?(robert.chira) → review-
Attachment #8520890 - Flags: review- → review?(robert.chira)
Conflict merged. We agreed about the Mock call proposal on IRC. Here we want to check that the call is correctly registered in the database.
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4) > Conflict merged. I meant conflict fixed.
QA Whiteboard: [fxosqa-auto-from-s3][fxosqa-auto-s4][fxosqa-auto-points=2] → [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-s5][fxosqa-auto-points=2]
Comment on attachment 8520890 [details] Gaia PR I left some comments on the PR. Since I don't know much about UI tests, they are suggestions more than anything.
Attachment #8520890 - Flags: review?(drs.bugzilla) → review-
Comment on attachment 8520890 [details] Gaia PR I used the parametrized tests to check both SIM1 and SIM2. I split the tests into 2 to handle both outgoing and incoming calls. Tell me what you think.
Attachment #8520890 - Flags: review- → review?(drs.bugzilla)
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #7) PR updated.
Comment on attachment 8520890 [details] Gaia PR Looks good. I left one question on the PR which I don't think requires anything other than awareness (it's your choice what to do with it). As I'm fairly unfamiliar with the UI tests and Marionette, my review is from a high level only.
Attachment #8520890 - Flags: review?(drs.bugzilla) → review+
Comment on attachment 8520890 [details] Gaia PR As Viorela said on Github: > I started an adhoc run and the tests are failing intermittently: > http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/361/console > I got the same failure while running the tests locally: https://pastebin.mozilla.org/7556840 > As I noticed, the call received/made was not displayed in call log. > Can you investigate this and see if you can reproduce the failure locally too? Thanks! This need more investigation on my side. I remove the reviews while I find something.
Attachment #8520890 - Flags: review?(viorela.ioia)
Attachment #8520890 - Flags: review?(robert.chira)
QA Whiteboard: [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-s5][fxosqa-auto-points=2] → [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-from-s5][fxosqa-auto-s6][fxosqa-auto-points=3]
I reproduce the issue locally but only after a fresh flash (like in the adhoc job). This might be a race condition when initializing the dialer for the very first time. I'll dig into it further.
After trying to clean the database after each test, I noticed that I have more intermittent failures[1]. I discussed that with :gsvelto and the problem must be that the CallLogDB transactions are not atomic. Let's wait the fix in bug 1112577. [1] http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/449/console
QA Whiteboard: [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-from-s5][fxosqa-auto-s6][fxosqa-auto-points=3] → [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-from-s5][fxosqa-auto-dropped-s6][fxosqa-auto-points=3]
It seems like I can't reproduce the issue locally. To be sure of it, I started http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/620/
Same as per bug 1096385 this should have been fixed by bug 1112577. Can you test and proceed to land your new test if it works?
Flags: needinfo?(jlorenzo)
Started adhoc job with 2*50 tries on test_dialer_dsds_incoming_call_log_recorded_sim.py: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/704/console Waiting for this job to finish to check with the second test (test_dialer_dsds_outgoing_call_log_recorded_sim.py).
37 failures/102 tries: 9 related to bug 1126260, 2 calls that couldn't be made and 26 due to the call log. With the screenshots[1], we still have the same issue. [1]
Flags: needinfo?(jlorenzo)
Gaia UI tests are not run or maintained anymore.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: