Closed Bug 1093697 Opened 10 years ago Closed 10 years ago

Unify Firefox Hello brand in the Loop Mobile application

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: oteo, Assigned: borjasalguero)

References

Details

(Whiteboard: [mobile app][Loop in v1.1][loop approved for 1.1])

Attachments

(6 files, 2 obsolete files)

Pull Request
(deleted), text/x-github-pull-request
crdlc
: review+
Details
bar.png
(deleted), image/png
Details
call_screen.png
(deleted), image/png
Details
homescreen.png
(deleted), image/png
Details
splash.png
(deleted), image/png
vicky
: ui-review+
Details
Patch to v1.1
(deleted), text/x-github-pull-request
Details
We need to review Firefox Hello brand in the Loop Mobile application, as it is shown with different names... e.g. in the call screen inside the bubble as "FxHello!", in the splash screen "Hello" and later "Firefox Hello!", in the Wizard "Firefox Hello"... and try to use a unique name
Flags: needinfo?(vpg)
Blocks: Loopmov_1_1
Summary: Unify Firefos Hello brand in the Loop Mobile application → Unify Firefox Hello brand in the Loop Mobile application
Assets are ready and uploaded to Box to be changed in the following places: Call screen: Generic thumbnail for local and remote Splash screen: splash screen logo Home screen: App icon Thanks!
Flags: needinfo?(vpg)
Assignee: nobody → borja.bugzilla
Status: NEW → ASSIGNED
Blocks: 1088993
No longer blocks: Loopmov_1_1
Attached file Pull Request (deleted) —
Attachment #8517390 - Flags: review?(josea.olivera)
Attached image Splash screen updated (obsolete) (deleted) —
Attachment #8517391 - Flags: ui-review?(vpg)
Attached image Thumbnail screen updated (obsolete) (deleted) —
Attachment #8517392 - Flags: ui-review?(vpg)
If we take this patch as it is right now the 'Hello!' string gets removed from the icon, is that what we want?
Flags: needinfo?(borja.bugzilla)
Please, update the assets as I have changed them for ones that I consider more suitable ;) Thanks!
(In reply to José Antonio Olivera Ortega [:jaoo] PTO till 11/24 from comment #6) > If we take this patch as it is right now the 'Hello!' string gets removed > from the icon, is that what we want? I left a comment Borja, thanks
Flags: needinfo?(borja.bugzilla)
Attachment #8517391 - Flags: ui-review?(vpg)
Attachment #8517392 - Flags: ui-review?(vpg)
Attached image bar.png (deleted) —
Attachment #8517391 - Attachment is obsolete: true
Attached image call_screen.png (deleted) —
Attachment #8517392 - Attachment is obsolete: true
Attached image homescreen.png (deleted) —
Attached image splash.png (deleted) —
Comment on attachment 8518848 [details] splash.png Global ui-review? for all images attached. Vicky, r? Thanks!!
Attachment #8518848 - Flags: ui-review?(vpg)
Attachment #8518848 - Flags: ui-review?(vpg) → ui-review+
Comment on attachment 8517390 [details] Pull Request Cristian, could you take care of it please? Thanks!
Attachment #8517390 - Flags: review?(josea.olivera) → review?(crdlc)
Comment on attachment 8517390 [details] Pull Request LGTM, thanks
Attachment #8517390 - Flags: review?(crdlc) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Borja, could you be so kind of uplifting the patch to 1.1 branch? Thanks a lot!
Flags: needinfo?(borja.bugzilla)
Whiteboard: [mobile app][Loop not in v1.1][loop approved for 1.1]
Attached file Patch to v1.1 (deleted) —
Flags: needinfo?(borja.bugzilla)
Merged in v1.1 :)
Whiteboard: [mobile app][Loop not in v1.1][loop approved for 1.1] → [mobile app][Loop in v1.1][loop approved for 1.1]
UI review was done only for the attachment with the flag. One of them did not pass the review. Next time put the corresponding flags in EACH item to be reviewd. Thanks.
Blocks: 1095623
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: