Closed
Bug 1094035
Opened 10 years ago
Closed 10 years ago
Keyed Histograms do not reflect key strings to JS correctly
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
Tracking | Status | |
---|---|---|
firefox33 | --- | unaffected |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
firefox36 | --- | fixed |
People
(Reporter: yfdyh000, Assigned: gfritzsche)
References
Details
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
froydnj
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Make a search in search bar using a non-ASSIC characters search name.
Open about:telemetry, click the Keyed Histograms to expand.
See a confusion of names in SEARCH_COUNTS.
Assignee | ||
Updated•10 years ago
|
Summary: Keyed Histograms does not show proper non-ASSIC characters → Keyed Histograms do not reflect key strings to JS correctly
Assignee | ||
Comment 1•10 years ago
|
||
[Tracking Requested - why for this release]:
This affects all "other-*" search engines for the "SEARCH_COUNTS" probe.
"SEARCH_DEFAULT_ENGINE" is also affected.
tracking-firefox34:
--- → ?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → georg.fritzsche
Assignee | ||
Updated•10 years ago
|
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8517519 -
Flags: review?(nfroyd)
Comment 3•10 years ago
|
||
Comment on attachment 8517519 [details] [diff] [review]
Pass the key string in proper encoding.
Sorry, should have caught that in review...
Attachment #8517519 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8517519 [details] [diff] [review]
Pass the key string in proper encoding.
Approval Request Comment
[Feature/regressing bug #]: Search telemetry, bug 1069874 et al.
[User impact if declined]: Search engines with non-ASCII strings show up garbled in search telemetry (probably limited to non-partner engines).
[Describe test coverage new/current, TBPL]: Extended automation coverage for this.
[Risks and why]: Low risk - small isolated string encoding issue.
[String/UUID change made/needed]: None.
Attachment #8517519 -
Flags: approval-mozilla-beta?
Attachment #8517519 -
Flags: approval-mozilla-aurora?
Comment 7•10 years ago
|
||
Comment on attachment 8517519 [details] [diff] [review]
Pass the key string in proper encoding.
This looks pretty safe. I would like to get this change into beta7, which goes to build tomorrow. I'm going to approve this for beta before it lands on m-c. If something breaks on m-c, we will need to back this out tomorrow before we go to build.
Flags: needinfo?(lmandel)
Attachment #8517519 -
Flags: approval-mozilla-beta?
Attachment #8517519 -
Flags: approval-mozilla-beta+
Attachment #8517519 -
Flags: approval-mozilla-aurora?
Attachment #8517519 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
tracking-firefox34:
? → ---
Assignee | ||
Comment 8•10 years ago
|
||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•