Closed Bug 1094505 Opened 10 years ago Closed 10 years ago

Avoid using concatenated name in installer

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Version:
36 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: canuckistani, Assigned: past)

References

Details

Attachments

(2 files, 1 obsolete file)

2014-11-04_1336.png
(deleted), image/png
Details
Avoid using concatenated name in installer v2
(deleted), patch
robert.strong.bugs
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image 2014-11-04_1336.png (deleted) —
See screenshot, it would be great if the installer displayed 'Firefox Developer Edition' instead of 'FirefoxDeveloperEdition'.
You probably meant this to block fx-dev-edition
Blocks: fx-dev-edition
No longer blocks: 1093870
Attached patch Avoid using concatenated name in installer (obsolete) (deleted) — — Splinter Review
I think this should work, assuming branding.nsi overrides defines.nsi.in. I want to push it on Gum to verify, but we decided to no longer treat Gum as our try server, so asking for review first.
Attachment #8517979 - Flags: review?(robert.strong.bugs)
Assignee: nobody → past
Status: NEW → ASSIGNED
Turns out you can't define something twice. Who knew?
Attachment #8519253 - Flags: review?(robert.strong.bugs)
Attachment #8517979 - Attachment is obsolete: true
Attachment #8517979 - Flags: review?(robert.strong.bugs)
Attachment #8519253 - Flags: review?(robert.strong.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/15d3dc8c5b63
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment on attachment 8519253 [details] [diff] [review] Avoid using concatenated name in installer v2 Approval Request Comment [Feature/regressing bug #]: Developer Edition feature, but the concatenated strings were introduced in bug 1072181 and bug 1090324 [User impact if declined]: users will see an ugly browser name in some parts of the Windows installer [Describe test coverage new/current, TBPL]: manual testing on try [Risks and why]: practically zero risk, as it's just a string change [String/UUID change made/needed]: a string was changed to a value that is already present, but it's not even one that is localized as far as I know
Attachment #8519253 - Flags: approval-mozilla-aurora?
Attachment #8519253 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: