Closed Bug 1094719 Opened 10 years ago Closed 7 years ago

[FxAccounts] Adopt Focus command from HierarchyManager in FxAccount UI

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: alive, Assigned: alive)

References

Details

Attachments

(1 file)

No description provided.
Attached file WIP (deleted) —
The purpose of this patch is to retain the focus when the system dialog is focused again by reordering the hierarchy. What we could do more is: record document.activeElement when FxAccounts is deactivated, and when it's being activated again, only call focus if the last document.activeElement is an input. Note: the patch is containing some change from bug 1079748; I will clean it up after bug 1079748 is landed. Lemme know what you think, and if there is a better to communicate with FxAClient I am listening. One more: Not sure how to integration test this; we don't have a keyboard library to simulate 'typing' behavior now. :/
Attachment #8518066 - Flags: feedback?(ferjmoreno)
Attachment #8518066 - Flags: feedback?(etienne)
Comment on attachment 8518066 [details] WIP I am afraid that I don't have enough knowledged about what the hierarchyManager does and how that affects to the FxA dialog, so I'll defer the feedback about the global picture to Etienne. WRT the FxA code, looks good to me. And AFAIK postMessage is the only way we have to communicate with the dialog content once it is loaded.
Attachment #8518066 - Flags: feedback?(ferjmoreno) → feedback+
Comment on attachment 8518066 [details] WIP Definite feedback+! Can we get this covered by a marionette test with a 'mozFxAccountsUnsolChromeEvent' dispatch?
Attachment #8518066 - Flags: feedback?(etienne) → feedback+
Assignee: nobody → ferjmoreno
Status: NEW → ASSIGNED
Assignee: ferjmoreno → alive
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: