Closed Bug 1094822 Opened 10 years ago Closed 10 years ago

[Messages][RTL] Number of group thread participants in Thread panel heading should always be LTR

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.1 S9 (21Nov)
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [sms-sprint-2.1S9])

Attachments

(2 files)

*** Leftover from bug 1080828 *** "(+1)" part of group thread heading ("Participant Name (+1)") should always be in LTR. Looks like I missed that somehow in patch for bug 1080828.
Attached file GitHub pull request URL (deleted) —
Hey Julien, Could you please take a look at this tiny patch, my unintentional leftover from bug 1080828 :( Thanks!
Attachment #8518162 - Flags: review?(felash)
Comment on attachment 8518162 [details] GitHub pull request URL r=me but as discussed on IRC we might want to use unicode markers so that gaia header is happy. So feel free to land if you want, or ask for another review with unicode markers instead.
Attachment #8518162 - Flags: review?(felash) → review+
(In reply to Julien Wajsberg [:julienw] from comment #2) > Comment on attachment 8518162 [details] > GitHub pull request URL > > r=me but as discussed on IRC we might want to use unicode markers so that > gaia header is happy. > > So feel free to land if you want, or ask for another review with unicode > markers instead. Unfortunately Gecko doesn't yet support the latest Unicode spec part related to bidirectional marks (see bug 1096421 and bug 922963), I don't see how we can handle this currently without html markup. So I landed this fix for now. Master: https://github.com/mozilla-b2g/gaia/commit/7befe4fc692f66d5f3b8981290ec59ab83741435
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [sms-sprint-2.1S8] → [sms-sprint-2.1S9]
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
Attached image verify_pass.png (deleted) —
This issue has been verified as pass on latest build of Flame 2.2&3.0 and Nexus 5 2.2&3.0 by STRs: Prerequisite: 1. Launch Message. 2. Send a MMS to a group. 3. Observe the heading at message dialog view. Results: Step3: The heading is shown as "(+1) LastName FirstName". "(+1)" part of group thread heading ("Participant Name (+1)") is always in LTR. See attachment:verify_pass.png Rate:0/3 Device: Flame 2.2 (pass) Build ID 20150526162504 Gaia Revision 15fa6e486b5c82956a8e8f8a99c39d297e8f0523 Gaia Date 2015-05-26 20:07:31 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/663bf4703588 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150526.201446 Firmware Date Tue May 26 20:14:55 EDT 2015 Bootloader L1TC000118D0 Device: Flame 3.0 (pass) Build ID 20150526160204 Gaia Revision 8ca93673869a64e09ed6153c5402896822dfb253 Gaia Date 2015-05-26 19:31:37 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac Gecko Version 41.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150526.195035 Firmware Date Tue May 26 19:50:45 EDT 2015 Bootloader L1TC000118D0 Device: Nexus 5 2.2 (pass) Build ID 20150526162504 Gaia Revision 15fa6e486b5c82956a8e8f8a99c39d297e8f0523 Gaia Date 2015-05-26 20:07:31 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/663bf4703588 Gecko Version 37.0 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150526.201116 Firmware Date Tue May 26 20:11:30 EDT 2015 Bootloader HHZ12f Device: Nexus 5 3.0 (pass) Build ID 20150526160204 Gaia Revision 8ca93673869a64e09ed6153c5402896822dfb253 Gaia Date 2015-05-26 19:31:37 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac Gecko Version 41.0a1 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150526.195039 Firmware Date Tue May 26 19:50:56 EDT 2015 Bootloader HHZ12f
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: