Closed
Bug 1094845
Opened 10 years ago
Closed 8 years ago
Resizer is not rendered when direction is RTL
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jfkthame, Assigned: karlt)
References
(Blocks 1 open bug)
Details
(Keywords: testcase)
Attachments
(2 files)
On Mac OS X, resizers (e.g. on a textarea) get an appropriate "mirrored" rendering when the direction is RTL.
However, on Linux the resizer simply doesn't render at all in the RTL case.
Once vertical-text support is enabled, this will also affect elements with writing-mode:vertical-rl (the typical mode for vertical East Asian content).
Assignee | ||
Comment 1•10 years ago
|
||
WFM with Clearlooks.
ISTR a reftest failing in the same way for a theme bug when we switched from Fedora to Ubuntu.
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #1)
> WFM with Clearlooks.
Interesting; so apparently it may be dependent on the theme or whatever.
> ISTR a reftest failing in the same way for a theme bug when we switched from
> Fedora to Ubuntu.
I see the bug on my Ubuntu 12.04LTS VM (with whatever the default theme is), after first noticing it on a tryserver run of a new testcase.
Sure enough, there are some tests in the "RTL mirroring tests" section of layout/reftests/native-theme/reftest.list that are marked skip-if(gtk2Widget). (The mention of bug 581086 in the comments there appears to relate to Windows, rather than the gtk2 failure here.)
Tracking back from those skip-if annotations, it looks like this was bug 519152, which was resolved as "invalid" in 2009. I'm inclined to think we should reconsider that resolution. Note that this will soon affect vertical Chinese/Japanese content as well as bidi cases (Arabic/Hebrew).
Assignee | ||
Comment 3•10 years ago
|
||
Yes, I think this is the same bug as bug 519152. I was thinking of bug 834724 and wasn't aware of bug 519152.
I wonder whether people using RTL will avoid Ambience. If not, I guess a workaround could be added to disable native resizers when Ambience is the theme.
I don't know whether it is worth it. Effort is probably better spent filing a bug for Ambience or its engine "murrine".
Comment 4•9 years ago
|
||
Karl,
Which distribution are you using? And which version of Clearlooks-phenix theme are you using? I ask because the Clearlooks-phenix theme is available (and it has 3 versions!) for several distributions and, in some distributions, I do not see the resizing grippy at the corner of blocks
eg:
http://community.linuxmint.com/img/screenshots/clearlooks-phenix-theme.png
Anyway, I can't find Clearlooks-phenix theme for my distribution or my desktop environment; I'm using Kubuntu 14.04.3 LTS and KDE 4.13.3.
- - - - -
This bug also affect blocks (not just <textarea>) with 'resize: both' and not just with 'direction: rtl':
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s31-resize-ui-vrl-002.xht
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s31-resize-ui-vlr-003.xht
I'm using Firefox 43.0a1 buildID=20150815090753
With Chrome 44.0.2403.155, I see the resizing grippy albeit it is at the wrong position in s31-resize-ui-vrl-002 .
Gérard
Comment 5•9 years ago
|
||
I think I found where to get that Clearlooks-phenix theme on my system.
He's the creator of that theme:
http://opendesktop.org/usermanager/search.php?username=jpfleury
I installed version 6 and still do not see any resizing grippy.
I will run more tests.
Comment 6•9 years ago
|
||
I now see the resizing grippy in my 2 tests thanks to changes in GTK3 theme (from oxygen-gtk to clearlooks-phenix-master) for GTK applications.
Comment 7•8 years ago
|
||
gtk3 addresses this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 8•8 years ago
|
||
Tests are disabled referencing this bug, so leaving open to track enabling the tests.
http://searchfox.org/mozilla-central/source/layout/reftests/writing-mode/reftest.list#21
Blocks: 1094434
Status: RESOLVED → REOPENED
Component: Widget: Gtk → Layout
Resolution: WORKSFORME → ---
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → karlt
Status: REOPENED → ASSIGNED
Reporter | ||
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8802815 [details]
bug 1094845 enable vertical writing mode textarea resizer tests
https://reviewboard.mozilla.org/r/87122/#review86152
Attachment #8802815 -
Flags: review?(jfkthame) → review+
Comment 11•8 years ago
|
||
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec43bb1d3fdb
enable vertical writing mode textarea resizer tests r=jfkthame
Comment 12•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•