See [0] for the reference impl. [0] https://github.com/johnmccutchan/ecmascript_simd/blob/master/src/ecmascript_simd.js

Should be straightforward. Contemplating the tests makes me think we could probably self-host the entire SIMD implementation...

Comment on attachment 8518194 [details] [diff] [review] SIMD: Add minNum/maxNum and update min/max in the interpreter Review of attachment 8518194 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this works. Or, you could just self-host these SIMD functions *and* Math.min/max. I'd assume that you'd still want Ion fast-paths as these operations can probably be turned into better specific instructions. That's entirely possible to do with self-hosted versions, and would speed up baseline, IIUC.

This updates the min/max operations for float32x4, according to the assembly sequences posted on the github repo.

Not sure this even needs a review, as it just moves patches, but anyways. This moves tests that were supposed to stay close to multiply/divide.

This adds helpers for using cmpps and not having these weird const integers show up at various places in the code, plus it's more consistent with x86's doc.

(Previous patch was using ss suffix instead of ps suffix. Rather silly for packed singles.)

Comment on attachment 8522238 [details] [diff] [review] Update SimdBinaryArith::Min/Max to properly handle comparisons involving -0/0 and NaNs Review of attachment 8522238 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!

Comment on attachment 8522238 [details] [diff] [review] Update SimdBinaryArith::Min/Max to properly handle comparisons involving -0/0 and NaNs Review of attachment 8522238 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!

Oh boy, even with pseudo code in front of the eyes, this gives headache to implement without blendvps and avx forms. Bleh.

Annnnnnnnd that will be done.

Comment on attachment 8522298 [details] [diff] [review] Add helpers for cmpps Review of attachment 8522298 [details] [diff] [review]: ----------------------------------------------------------------- Please define an enum in BaseAssembler-x86-shared.h for the actual constants, similar to the Condition enum. That will make it less important to make the cmpps interface private, but I'm ok either way. I do like it that the code now uses cmpltps and friends.

Comment on attachment 8522379 [details] [diff] [review] Implement SIMD.float32x4.minNum/maxNum in the JITs Review of attachment 8522379 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e21104ba9205 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/cecc072d44bc remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8937c8785f74 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd252c4cfad remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7ba8aa473d3 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd68fda05a2b

https://hg.mozilla.org/mozilla-central/rev/e21104ba9205 https://hg.mozilla.org/mozilla-central/rev/cecc072d44bc https://hg.mozilla.org/mozilla-central/rev/8937c8785f74 https://hg.mozilla.org/mozilla-central/rev/dcd252c4cfad https://hg.mozilla.org/mozilla-central/rev/f7ba8aa473d3 https://hg.mozilla.org/mozilla-central/rev/dd68fda05a2b