Chrome, IE and Safari migrators should be using the new async API.

This is very trivial. The terrible migration UI is async-friendly :) We'll just need to test this very carefully (there are no automated tests), and make sure QA focuses on testing the migrators.

Attaching current patch, I must still do manual testing of the migration.

IE and Chrome are OK. now testing Safari.

tested Safari (clearly with the dependency bug fixed)

Comment on attachment 8594032 [details] [diff] [review] patch v1.2 Review of attachment 8594032 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks for all the manual testing! ::: browser/components/migration/ChromeProfileMigrator.js @@ +62,2 @@ > > + insertBookmarkItems(newFolderGuid, item.children); yield insertBookmarkItems(...); @@ +192,5 @@ > + }, > + (inputStream, resultCode) => { > + if (!Components.isSuccessCode(resultCode)) > + reject(new Error("Could not read Bookmarks file")); > + resolve(inputStream); I know we can't resolve a rejected promise but maybe use "else" to the code a little clearer? ::: browser/components/migration/IEProfileMigrator.js @@ +209,5 @@ > + folderGuid = yield PlacesUtils.bookmarks.insert({ > + type: PlacesUtils.bookmarks.TYPE_FOLDER, > + parentGuid: aDestFolderGuid, > + title: entry.leafName > + }); Shouldn't that set folderGuid to the .guid property of the bookmark? ::: browser/components/migration/SafariProfileMigrator.js @@ +153,5 @@ > if (type == "WebBookmarkTypeList" && entry.has("Children")) { > let title = entry.get("Title"); > + let newFolderGuid = yield PlacesUtils.bookmarks.insert({ > + parentGuid, type: PlacesUtils.bookmarks.TYPE_FOLDER, title > + }); Shouldn't newFolderGuid be set to the .guid property?

yep, good catches

Regression testing was performed today using Firefox 40 Beta 4 on: Win 7 x86, Win 10 x64, Mac OS X 10.9.5, Ubuntu 14.04 x64. No new issues were found during testing. Detailed test results can be found at: https://docs.google.com/spreadsheets/d/1ZGOcdnEVy8RC1OPf2YPzKNPY3Df9lLmrdKarwjPcbFA/edit#gid=34497851. Marking this as Verified.