Closed
Bug 1095028
Opened 10 years ago
Closed 10 years ago
Allow autolanding for non-suggested reviewers if the patch is authored by a suggested reviewer
Categories
(Firefox OS Graveyard :: Gaia::GithubBot, defect)
Firefox OS Graveyard
Gaia::GithubBot
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
This was intended, but it appears that we lose the 'requestee' field from flags after they are set. Perhaps we could either ask the bugzilla team to persist this in the API, or we could check the pull request author.
Reporter | ||
Comment 1•10 years ago
|
||
In order to do this we will need to set up a bugzilla testing account which is not a suggested reviewer. I'm not sure if there's an API to do this, but if there's not we can register an account and hang it off of the autolander gmail account.
For production I've registered the following account: bug.autolander+test1@gmail.com
Unfortunately for the bugzilla-dev instance, I don't have permissions to create users there yet, nor does it send email. If we want to go down this path we need to create the user on the dev instance, and also give write permissions to both instances.
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8555434 [details]
[PullReq] KevinGrandon:bug_1095028_suggested_review_requestee to mozilla:master
Could either of you guys review this?
Note: I still need to get the flag activity API landed here before this can land: https://github.com/canuckistani/bz.js/pull/23
Attachment #8555434 -
Flags: review?(jlal)
Attachment #8555434 -
Flags: review?(garndt)
Comment 4•10 years ago
|
||
Comment on attachment 8555434 [details]
[PullReq] KevinGrandon:bug_1095028_suggested_review_requestee to mozilla:master
Looks good, also saw that the PR on the other repo landed.
Attachment #8555434 -
Flags: review?(garndt) → review+
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8555434 [details]
[PullReq] KevinGrandon:bug_1095028_suggested_review_requestee to mozilla:master
Thanks.. yeah, we should be good here now.
Attachment #8555434 -
Flags: review?(jlal)
Reporter | ||
Comment 6•10 years ago
|
||
I've decided to go with a forked bz module[1] for now as I'm not a maintainer of the current one on npm, and I needed to publish a new 1.x version with my patch applied. Will work to upstream these changes.
[1] https://www.npmjs.com/package/kg-bz
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/autolander/commit/a7d31b902d809eaf976a5a3b05ffc698b476547e
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•