In the latest nightly, Linux 2001110921, clicking on a folder on the personal toolbar no longer works. It just displays an empty menu popup. Clicking on the "Bookmarks" folder on the Personal Toolbar works still, but any bookmark folders don't. Possibly related: the tooltips for all toolbars also display empty tooltips.

this wfm in the latest win trunk build, 2001110903

I think the problem is not limited to the bookmarks or folders: With my latest Linux build 2001110921, no bookmarks are shown in the pull-down bookmarks folder. Adding folders to the personal toolbar pops up two error boxes. When editing bookmarks, I do not get the bookmarks stored in a certain folder. The same problem occurs when you use Mozilla as file-browser under Linux. If I type '/' in the location bar, I get the list of all directories, but when I click on the 'expand' button, the files in that directory are not shown. If I doubleclick on the folder, the location gets changed. I think there is something wrong with the treestructure that is used troughout Mozilla... Maybe someone has an idea under which heading this bug should be classified?

I just downloaded this morning's 2001111006 build to see if the problem went away, and unfortunately it's still there. Adding some keywords. Regresion is obvious, pp since it's reported to be fine on windows.

I see this also on linux, build pulled at 0900GMT.

None of the folders in my Bookmarks menu work, they are all empty. This will stop a large number of people using the product until it's fixed. Marking as a blocker for this reason, although if the powers-that-be disagree, please go back to Critical. Note that this borders on a smoketest blocker.

Resummarising based on what I see.

I have a bad feeling this may involve the checkin for bug 106749... i'll back it out and check.

Yup, backing out the fix for bug 106749 appears to fix this, which is depressing. cvs update -j1.19 -j1.18 mozilla/content/xul/templates/src/nsXULContentBuilder.cpp -> waterson/XUL

Pfuck.

Dumb typo. Use the iterator variable, you moron.

Trivial fix checked in, sans review.

.

Changing Platform/OS to All/All. Verifying fixed with a fresh CVS build in WindowsME (a build made 30 min before the fix had the problem). I hope Asa will not smither me for not verifying on Linux and Mac, but as the reason behind this bug was a typo, I believe confirming on one platform will do.

*** Bug 109538 has been marked as a duplicate of this bug. ***

Comment on attachment 57368 [details] [diff] [review] one-line fix I've done something eerily similar in the JS GC, where acx and cx are two pointers (there, acx is the iterator!). r/sr=brendan@mozilla.org after the fact. Did this make it into the 0.9.6 branch? /be

Fortunately not. I've incorporated the fix into the patch for bug 106749, which is still awaiting approval.

*** Bug 109555 has been marked as a duplicate of this bug. ***

yup, W2K is broken also with this morning build. 11-10

*** Bug 109563 has been marked as a duplicate of this bug. ***

*** Bug 109591 has been marked as a duplicate of this bug. ***

*** Bug 109631 has been marked as a duplicate of this bug. ***

*** Bug 109657 has been marked as a duplicate of this bug. ***