Closed Bug 1095297 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird36 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 36.0
Tracking Flags:
Tracking Status
thunderbird36 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bug1095297.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_install_corrupt_xpi TEST-START | /builds/slave/test/build/mozmill/content-tabs/test-install-xpi.js | test_install_xpi_offer Step Pass: {"function": "controller.click()"} JavaScript error: chrome://messenger/content/specialTabs.js, line 1238: TypeError: installInfo is undefined Test Failure: Timeout waiting for alert
Attached patch bug1095297.patch (deleted) — — Splinter Review
Attachment #8518657 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8518657 [details] [diff] [review] bug1095297.patch r=me if you'll accept that
Comment on attachment 8518657 [details] [diff] [review] bug1095297.patch Review of attachment 8518657 [details] [diff] [review]: ----------------------------------------------------------------- Thx Hiro! r=mkmelin I'll update the comment and land it in a moment ::: mail/base/content/specialTabs.js @@ +1232,5 @@ > > let installInfo = aSubject.QueryInterface(Ci.amIWebInstallInfo); > // If not e10s, the window installing the add-ons, otherwise the > // browser installing the add-ons. > // XXX: needs reworking to do something useful if it's a browser. This comment is no longer valid.
Attachment #8518657 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/ef5744e3d155 -> FIXED
Assignee: nobody → hiikezoe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Blocks: 1094706
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: