A logic error means e10s remains enabled on OSX when HW acceleration is disabled and it is broken. Gijs, can you see if this patch properly disabled e10s for you?

(In reply to Dave Townsend [:mossop] from comment #0) > Created attachment 8518997 [details] [diff] [review] > patch > > A logic error means e10s remains enabled on OSX when HW acceleration is > disabled and it is broken. > > Gijs, can you see if this patch properly disabled e10s for you? I used accelDisabled |= ..., and that works, so logically speaking, this does too. :-) Thanks!

Comment on attachment 8518997 [details] [diff] [review] patch What about the other bits of that function? 4655 4656 // Check env flags 4657 if (accelDisabled) { 4658 const char *acceleratedEnv = PR_GetEnv("MOZ_ACCELERATED"); 4659 if (acceleratedEnv && (*acceleratedEnv != '0')) { 4660 accelDisabled = false; 4661 } 4662 } is kind of odd - is it mean to deal with the case where the prefs/hardware disable HWA, and then you force it on?

Comment on attachment 8518997 [details] [diff] [review] patch lrtm

Yeah that doesn't look right either. Also apparently we want to fix bug 1089008 so I might as well do that while I'm here...

Actually let's land this known good patch here and I'll solve the other issue separately. https://hg.mozilla.org/integration/fx-team/rev/f7ba147a8b5f

This merged in https://hg.mozilla.org/mozilla-central/rev/f7ba147a8b5f but mc-merge failed to mark this bug.