Closed
Bug 1096430
Opened 10 years ago
Closed 10 years ago
Panel UI separator icon is wrong for Australis in dev edition 35
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 35
Tracking | Status | |
---|---|---|
firefox35 | --- | fixed |
firefox36 | --- | unaffected |
People
(Reporter: johan.charlez, Assigned: bgrins)
References
Details
(Whiteboard: [devedition-polish])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
dao
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: disable the Developer Edition theme
Actual result: separator looks buggy (see screenshot).
Since posting this I've noticed that the menu icon looks scaled down. You can see this clearly in the screenshot posted above.
Assignee | ||
Comment 2•10 years ago
|
||
I think this is the same thing Tim was seeing. I'll look into it.
Assignee | ||
Comment 3•10 years ago
|
||
I don't see this on m-c with a tip of 0c66a9fd9085 (https://hg.mozilla.org/mozilla-central/rev/0c66a9fd9085) so it must have landed after that. A likely candidate is Bug 1094509
Assignee | ||
Comment 4•10 years ago
|
||
Weird thing is that I don't see this locally on a build, but I do in the devedition release. Makes me thing something didn't get uplifted to aurora.
Assignee | ||
Updated•10 years ago
|
Summary: Firefox Developer Edition Theme not fully disabled. → Panel UI separator icon is wrong for Australis in dev edition 35
Please take comment #1 into account as well
Assignee | ||
Comment 7•10 years ago
|
||
Copying over panelUIOverlay.inc.css from fx-team to aurora doesn't fix it. Still trying to track it down
Updated•10 years ago
|
Whiteboard: [devedition-polish]
Assignee | ||
Comment 8•10 years ago
|
||
I'm not sure why, but switching 'transparent' to 'rgba(255, 255, 255, 0)' in this gradient fixes it:
http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#24-26
Assignee | ||
Comment 9•10 years ago
|
||
I wonder if it's somehow interacting with not having this changeset on aurora: https://hg.mozilla.org/mozilla-central/rev/3adeab7e472d.
Assignee | ||
Comment 10•10 years ago
|
||
So, starting/ending at 'transparent' instead of 'hsla(0,0%,100%,0)' in the gradients for the panel ui button is causing issues on aurora. I'm guessing that if we uplifted all of https://hg.mozilla.org/mozilla-central/raw-rev/3adeab7e472d it would solve this problem also, but this is a much simpler fix.
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Johan C from comment #6)
> Please take comment #1 into account as well
I'm also seeing a smaller panel button in osx/windows 7 (but not on nightly). Maybe an icon change that wasn't uplifted? I'll see if I can track that down.
Reporter | ||
Comment 12•10 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #11)
> (In reply to Johan C from comment #6)
> > Please take comment #1 into account as well
>
> I'm also seeing a smaller panel button in osx/windows 7 (but not on
> nightly). Maybe an icon change that wasn't uplifted? I'll see if I can
> track that down.
It looks squashed, if you compare the icons in the screenshot you can see that the icon is wider on the beta channel.
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #11)
> (In reply to Johan C from comment #6)
> > Please take comment #1 into account as well
>
> I'm also seeing a smaller panel button in osx/windows 7 (but not on
> nightly). Maybe an icon change that wasn't uplifted? I'll see if I can
> track that down.
This appears to be a regression from 1080406, where there is a call to PanelUI.menuButton.classList.add("badged-button"). It's not clear to me why this is a problem only on DevEdition. Matteo, any ideas why the panel ui button is smaller in the DevEdition release?
Updated•10 years ago
|
Attachment #8520179 -
Flags: review?(dao) → review+
Comment 15•10 years ago
|
||
Comment on attachment 8520179 [details] [diff] [review]
aurora-panel-separator-fix.patch
Just to be clear, this patch shouldn't land on mozilla-central.
Assignee | ||
Comment 16•10 years ago
|
||
Comment on attachment 8520179 [details] [diff] [review]
aurora-panel-separator-fix.patch
Approval Request Comment
[Feature/regressing bug #]: 1053434
[User impact if declined]: The separator for the panel button in australis is wrong
[Describe test coverage new/current, TBPL]: style change
[Risks and why]: Just changing 'transparent' to 'hsla(0,0%,100%,0)' in a css property
[String/UUID change made/needed]:
Attachment #8520179 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 17•10 years ago
|
||
Moved needinfo to 1097062, since it is a different problem
Flags: needinfo?(zer0)
Updated•10 years ago
|
Attachment #8520179 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 18•10 years ago
|
||
Note: attachment 8520179 [details] [diff] [review] is meant only for aurora uplift, not for landing on m-c
Comment 19•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox35:
--- → fixed
status-firefox36:
--- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•