Closed Bug 109651 Opened 23 years ago Closed 23 years ago

The [X] cross in tab bar should be disabled when there is only one tab.

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.1alpha

People

(Reporter: seb, Assigned: jag+mozilla)

References

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

Go to Edit > Preferences > Navigator > Tabbed Browsing and be sure that "Hide the tab bar when only one tab is open" is unchecked. Open your Mozilla browser. Try clicking on the [X] cross in the tab bar. It does nothing. It should either close the whole Mozilla browser window (like Ctrl-W does when there is only one tab) or not be displayed at all when there is only one tab. That occurs on build 2001111108 on W2K.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
I guess it'd be best to display it grayed out, so people know it is still there, but don't expect it to do anything.
spam: set your filter for "SeverusSnape" to avoid the influx of bugmail changing QA contact of open tabbed browser bugs from blake to me. if this bug requires a reassignment, however, feel free to change it!
QA Contact: blakeross → sairuh
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1
*** Bug 112694 has been marked as a duplicate of this bug. ***
*** Bug 116787 has been marked as a duplicate of this bug. ***
Reassigning to new component owner.
Assignee: hyatt → jaggernaut
Status: ASSIGNED → NEW
*** Bug 121794 has been marked as a duplicate of this bug. ***
*** Bug 124881 has been marked as a duplicate of this bug. ***
Bug 124881 was about showing about:blank when the user tries to close the last tab. I think that's what should be done here. The user tries to close the tab because he or she wants to leave the site. Because the last tab cannot be closed, a blank page should be loaded instead.
nsbeta1- per ADT triage team
Keywords: nsbeta1nsbeta1-
jag, do you have any preference for this? There appear to be at least four options for when only one tab is open: 1) The close button closes the window 2) The close button is disabled 3) The close button is hidden 4) When the last tab is closed a new one is created
It shouldn't be hidden, since we'll probably add two more buttons there (New, Add tab set as bookmark group), so hiding the close box would make those jump. I prefer just disabling it. Were you volunteering to write that patch?
Nah, just disable the button, and that is my final answer ;-)
Attached patch Disable the close button when only one tab open (obsolete) (deleted) — Splinter Review
Attachment #71314 - Attachment is obsolete: true
Comment on attachment 71448 [details] [diff] [review] Disable the close button when only one tab open I'd prefer closebuttondisabled, but that's rather long. closedisabled? sr=jag for the mechanism, find some better name though.
Attachment #71448 - Flags: superreview+
I like the idea of showing about:blank but keeping the window open... Maybe close the current tab, open about:blank, and disable the close button? Then enable it when (1) a new tab is opened or (2) a new page is loaded in the about:blank tab? Just my 2¢...it would be nice to close the current page (happens when closing any other tabs) and also keep the window open (also the behavior when closing another tab).
Comment on attachment 72066 [details] [diff] [review] using disableclose instead of noclose sr=jag
Attachment #72066 - Flags: superreview+
Neil, could you get r= and a=?
Summary: The [X] cross in tab bar doesn't work when there is only one tab. → The [X] cross in tab bar should be disabled when there is only one tab.
Attachment #72066 - Flags: review+
Attachment #71448 - Attachment is obsolete: true
That was an r=timeless.
Comment on attachment 72066 [details] [diff] [review] using disableclose instead of noclose a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72066 - Flags: approval+
fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
vrfy'd fixed using 2002.03.26.0x comm verif bits on linux rh7.2, mac 10.1.3 and win2k. the 'X' button when there's only one tab is now disabled --except that it still visually depresses when i click it. niggling as it is, why isn't the button just greyed out? or, is that a separate bug?
Status: RESOLVED → VERIFIED
sariuh, sorry, I forgot to check the appearance on Modern :-( Actually the [X] isn't greyed out on Classic as you might expect. I have filed bug 133685 on the issue.
This would appear to have inadvertently caused bug 137057 as, in modern theme, the disabled tabs close button is picking up some unwanted styles from .toolbarbutton[disabled="true"]
This behavior has been seen again in recent builds as a result of bug 150099. I propose reopening this bug, marking it regression, and depping it to bug 150099. See bug 150099 comment #28.
The reason that it's no longer disabled is that it has a new function. Previously we had an enabled button that did nothing. Now we have an enabled button that does something.
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: