Closed
Bug 1096745
Opened 10 years ago
Closed 10 years ago
The div:last-child rule from lockscreen makes unnecessary restyle when appendChild() to #windows div
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S9 (21Nov)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: ting, Assigned: ting)
References
Details
Attachments
(1 file, 1 obsolete file)
There's another unnecessary restyle when appendChild() to #windows, it's because #windows has NODE_HAS_EDGE_CHILD_SELECTOR flag set from lockscreen/style/notifications.css:
#notifications-lockscreen-container > div:last-child::after
Since lockscreen.html now is integrated to system app (#lockscreen-frame-placeholder), import the CSS with limited scope can avoid this.
|
Assignee | |
Updated•10 years ago
|
Summary: The last-child rule from lockscreen makes #windows → The div:last-child rule from lockscreen makes unnecessary restyle when appendChild() to #windows div
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8520360 [details]
PR
OK. I've tested this on my device. It looks fine and thanks for your patch.
Attachment #8520360 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Passcode input pad is not shown with the patch:
TEST-UNEXPECTED-ERROR | test_lockscreen_unlock_to_homescreen_with_passcode.py TestLockScreen.test_unlock_to_homescreen_with_passcode | TimeoutException: TimeoutException: Timed out after 10.0 seconds
Also from logcat I see:
W/GeckoConsole(20502): [JavaScript Warning: "Property contained reference to invalid variable. Error in parsing value for 'transition-duration'. Falling back to 'initial'." {file: "app://system.gaiamobile.org/lockscreen/style/lockscreen.css" line: 263 column: 5464 source: " opacity var(--panel-transition-secs) ease"}]
I'll check those.
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8520360 [details]
PR
OK. I've re-flash it completely and the error occur. It looks like the old code (I now pull it directly from device to check it) has been pushed into the device, I should using make reset-gaia instead of make install-gaia. Please set the flag again if you fixed the issue.
Attachment #8520360 -
Flags: review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Addressed the issues of comment 3.
Attachment #8520360 -
Attachment is obsolete: true
Attachment #8521277 -
Flags: review?(gweng)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8521277 [details]
PR v2
OK. I now flash it twice to check if the patch is fine. Thanks.
Attachment #8521277 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
|
|
Assignee | |
Updated•10 years ago
|
Blocks: AppStartup
You need to log in
before you can comment on or make changes to this bug.
Description
•