Closed Bug 1096917 Opened 10 years ago Closed 10 years ago

hghooks: push_printurls.py should output hgweb URLs for Try pushes too

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4085] )

Attachments

(1 file)

Currently for pushes to non-Try repos, we output links to hgweb (either the changeset URLs or if the number of pushes is large, the pushloghtml URL). For Try pushes we don't do this, and instead link only to Treeherder/TBPL. I propose we do both for Try repos. Note there is the related bug 1062620 - but that is in the other direction (ie output both for non-try) - which requires (marginally) more effort, since we need to differentiate between Treeherder-using and non-Treeherder-using repos. As such, keeping this separate from that bug.
Blocks: 1084493
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4085]
Currently hgweb URLs are only output for non-try pushes & try pushes just get a link to Treeherder/TBPL. However I believe it's still useful to output the hgweb URL for try, since devs wanting to check their commits can do so without having to go via Treeherder (and thus having to wait for it to ingest the push). This patch means that we output hgweb URLs for all pushes. The order of the hook is changed, since IMO it makes more sense for the revision link to be output before any results link.
Attachment #8521867 - Flags: review?(gps)
Comment on attachment 8521867 [details] [diff] [review] hghooks: make push_printurls.py output hgweb URLs for Try pushes too Review of attachment 8521867 [details] [diff] [review]: ----------------------------------------------------------------- Great patch. I love how the new state of the code is simpler and has one logical flow. Thanks for fixing the bad English in the comment.
Attachment #8521867 - Flags: review?(gps) → review+
I don't suppose you could deploy this for me? :-)
Flags: needinfo?(gps)
Deployed.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(gps)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: