Closed
Bug 1097246
Opened 10 years ago
Closed 10 years ago
gecko: Branch configs
Categories
(Taskcluster :: General, defect)
Taskcluster
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Assigned: garndt)
References
Details
Attachments
(2 files, 1 obsolete file)
This should be very similar to what we have going on with try I imagine a format like this:
taskcluster/branches/<branch>
So in the taskcluster/branches/mozilla-central.yml we would list a set of tasks (and for aurora, etc...). When the decision task runs it should determine if its in "try mode" (and if so use try) otherwise use the branch configs (in the case of unknown branch nothing should happen).
(not not going to assign myself yet but I would like to take this one if possible)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → garndt
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8540950 -
Flags: review?(jlal)
Assignee | ||
Comment 2•10 years ago
|
||
/r/1677 - Bug 1097246 - Created branched configs r=lightsofapollo
Pull down this commit:
hg pull review -r c1b14139e036d59caa7c281d250cc7225125c6ab
Assignee | ||
Comment 3•10 years ago
|
||
/r/1677 - Bug 1097246 - Created branched configs r=lightsofapollo
/r/1685 - Bug 1097246 - Fixed README for trygraph r=lightsofapollo
Pull down these commits:
hg pull review -r 378d002476bd3637d305377d04dbd72726bdf085
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8540950 [details]
MozReview Request: bz://1097246/garndt
Redirecting review to wcosta but I will address comments.
Attachment #8540950 -
Flags: review?(jlal) → review?(wcosta)
Comment 5•10 years ago
|
||
https://reviewboard.mozilla.org/r/1675/#review1151
::: testing/taskcluster/mach_commands.py
(Diff revision 2)
> - job_graph = parse_commit(params['message'], jobs)
> + job_path = job_path if os.path.exists(job_path) else DEFAULT_JOB_PATH
Since the user must pass the --project argument, shouldn't be better to raise an error in case of an invalid project?
Comment 6•10 years ago
|
||
One nit comment, otherwise lgtm
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Wander Lairson Costa [:wcosta] from comment #5)
> https://reviewboard.mozilla.org/r/1675/#review1151
>
> ::: testing/taskcluster/mach_commands.py
> (Diff revision 2)
> > - job_graph = parse_commit(params['message'], jobs)
> > + job_path = job_path if os.path.exists(job_path) else DEFAULT_JOB_PATH
>
> Since the user must pass the --project argument, shouldn't be better to
> raise an error in case of an invalid project?
We could create a white list of projects, but the way it is now, any branches we are not aware of will just default to using the mozilla-central job configuration. I'm open for the idea of a branch whitelist if we want to restrict things.
Updated•10 years ago
|
Attachment #8540950 -
Flags: review?(wcosta) → review+
Assignee | ||
Comment 8•10 years ago
|
||
http://hg.mozilla.org/projects/alder/rev/21aa76d8d003
http://hg.mozilla.org/projects/alder/rev/c02f2950c105
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8540950 -
Attachment is obsolete: true
Attachment #8618605 -
Flags: review+
Attachment #8618606 -
Flags: review+
Assignee | ||
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
Updated•9 years ago
|
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Comment 13•9 years ago
|
||
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•