Closed Bug 1097564 Opened 10 years ago Closed 10 years ago

Support promise for NFC related WebAPI

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S9 (21Nov)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(1 file, 4 obsolete files)

pull request to mozilla-b2g/gaia v1
(deleted), text/x-github-pull-request
alive
: review+
Details
After bug 996397 landed, NFC WebAPI will use Promise instead of DOMRequest, so GAIA apps use NFC api should support promise before landing bug 996397
Summary: Support NFC related WebAPI return promise → Support promise for NFC related WebAPI
Attached file pull request to mozilla-b2g/gaia v1 (obsolete) (deleted) —
Hi Alive, Could you help review this bug ? Thanks!
Attachment #8521341 - Flags: review?(alive)
Comment on attachment 8521341 [details] pull request to mozilla-b2g/gaia v1 cancel review because of test failure
Attachment #8521341 - Flags: review?(alive)
Attached patch WIP Patch v1 (obsolete) (deleted) — — Splinter Review
Attachment #8521341 - Attachment is obsolete: true
Attached patch WIP Patch v2 (obsolete) (deleted) — — Splinter Review
Attachment #8522643 - Attachment is obsolete: true
Attached patch WIP Patch v3 (obsolete) (deleted) — — Splinter Review
fix error when run "make lint"
Attachment #8523674 - Attachment is obsolete: true
Attached file pull request to mozilla-b2g/gaia v1 (deleted) —
Attachment #8523712 - Attachment is obsolete: true
Attachment #8523799 - Flags: review?(alive)
Comment on attachment 8523799 [details] pull request to mozilla-b2g/gaia v1 I don't think promise will fix function scope of |this| for you. Please check.
Attachment #8523799 - Flags: review?(alive)
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7) > Comment on attachment 8523799 [details] > pull request to mozilla-b2g/gaia v1 > > I don't think promise will fix function scope of |this| for you. Please > check. Hi Alive, I use |this| instead of |self| because of arrow function will bind this value. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions Could you help check again ? Thanks!
Flags: needinfo?(alive)
Comment on attachment 8523799 [details] pull request to mozilla-b2g/gaia v1 yeah, sorry missing that
Flags: needinfo?(alive)
Attachment #8523799 - Flags: review+
Keywords: checkin-needed
remove checkin-needed because of not adding r=alive to commit message
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/ed3f969b4a8ceab340ae7c1a1e7fb8af8c2a897d
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: