Closed
Bug 1098245
Opened 10 years ago
Closed 10 years ago
Avoid cropping tab curve when selected tab is partially visible
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Showing partially visible selected tab on the left is not a problem because it's the edge of the screen anyway. I'm not concerned about how it looks when the partially visible selected tab is displayed beside the "new tab" button.
Thoughts?
APK: https://dl.dropboxusercontent.com/u/1187037/snap-selected-tab.apk
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(alam)
Comment 1•10 years ago
|
||
Feels good on my N9.
I think (although temporary) the overlap of the active tab and the dark background behind the + icon is weird.
Can we get some more fading there?
Flags: needinfo?(alam) → needinfo?(lucasr.at.mozilla)
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Anthony Lam (:antlam) from comment #1)
> Feels good on my N9.
>
> I think (although temporary) the overlap of the active tab and the dark
> background behind the + icon is weird.
>
> Can we get some more fading there?
I had to disable the fading edge due to performance issue. Bug 1090364 got reopened as a result. I'll restore the fading edge with a new implementation.
Flags: needinfo?(lucasr.at.mozilla)
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8523843 -
Flags: review?(michael.l.comella)
Assignee | ||
Updated•10 years ago
|
Priority: -- → P1
Comment 4•10 years ago
|
||
Comment on attachment 8523843 [details] [diff] [review]
Avoid cropping tab curve when selected tab is partially visible (r=mcomella)
Review of attachment 8523843 [details] [diff] [review]:
-----------------------------------------------------------------
What is the motivation for this? To make the abrubtness of a selected tab under the + button stand out less?
I imagine this behavior could be slightly annoying (e.g. swiping left-to-right, looking for a tab on the left, finding it so releasing your finger, and having it get pushed off-screen to get the selected tab on-screen - most people aren't focused on the selected tab at this point and so it could be unintuitive).
I'm ambivalent about this change, but the implementation looks correct.
Attachment #8523843 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #4)
> Comment on attachment 8523843 [details] [diff] [review]
> Avoid cropping tab curve when selected tab is partially visible (r=mcomella)
>
> Review of attachment 8523843 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> What is the motivation for this? To make the abrubtness of a selected tab
> under the + button stand out less?
>
> I imagine this behavior could be slightly annoying (e.g. swiping
> left-to-right, looking for a tab on the left, finding it so releasing your
> finger, and having it get pushed off-screen to get the selected tab
> on-screen - most people aren't focused on the selected tab at this point and
> so it could be unintuitive).
>
> I'm ambivalent about this change, but the implementation looks correct.
Honestly, I'm mixed about it too. Let me first re-implement the fading edge to if it's enough. I'll put this patch on hold for now.
Assignee | ||
Comment 6•10 years ago
|
||
Anthony, I realize the shadow we have now is not ideal but I feel we shouldn't implement this behaviour. Do you feel strongly about this?
Flags: needinfo?(alam)
Updated•10 years ago
|
tracking-fennec: --- → ?
Updated•10 years ago
|
tracking-fennec: ? → 36+
Summary: Experiment: Avoid cropping tab curve when selected tab is partially visible → Avoid cropping tab curve when selected tab is partially visible
Comment 7•10 years ago
|
||
After speaking with :antlam, closing in favor of bug 1111820.
Status: NEW → RESOLVED
tracking-fennec: 36+ → ---
Closed: 10 years ago
Flags: needinfo?(alam)
Resolution: --- → WONTFIX
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•