Closed
Bug 1098296
Opened 10 years ago
Closed 10 years ago
addLivemark should take a dateAdded input property
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
See my comment about NewLivemark in bug 1095425.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Iteration: --- → 36.3
Points: --- → 3
Flags: qe-verify-
|
|
Assignee | |
Updated•10 years ago
|
Flags: firefox-backlog+
|
||
Updated•10 years ago
|
Iteration: 36.3 → 37.1
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8527633 [details] [diff] [review]
patch
Review of attachment 8527633 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/nsLivemarkService.js
@@ +426,5 @@
> onItemChanged: function LS_onItemChanged(aItemId, aProperty, aIsAnno, aValue,
> aLastModified, aItemType)
> {
> if (aItemType == Ci.nsINavBookmarksService.TYPE_FOLDER) {
> + if (aLastModified != 0 &&
please fix the bookmarks idl instead, we never pass zero as lastModified, so you can restore most of the old code
@@ +438,5 @@
> + else if (aProperty == "dateAdded") {
> + this._livemark[aItemId].dateAdded = parseInt(aValue, 10);
> + }
> +
> + if (aLastModified != 0)
ditto
Attachment #8527633 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•