Bogdan Maris, Desktop QA Reporter
	Description • 10 years ago

STR:
1. Open latest Nightly
2. Open about:welcomeback
3. Click 'Restore only the ones you want'
4. Go to urlbar and write a link. eg: https://www.mozilla.org/en-US/
5. Hit Enter.

Expected results: The page loads.

Actual results: Page does not load if the option is selected.

Notes:
1. This happens across all platforms.

	Mike Conley (:mconley) (:⚙️)
	Comment 1 • 10 years ago

I'm unable to reproduce this with a fresh build. Do you still see this in the latest Nightly, Bogdan?

	Bogdan Maris, Desktop QA Reporter
	Comment 2 • 10 years ago

I can still reproduce using latest Nightly on Windows 8.1, Ubuntu 14.04 64 and Mac OS X 10.9.5.

	Mike Conley (:mconley) (:⚙️)
	Comment 3 • 10 years ago

Oh weird - now I can reproduce it too. I must have been doing it wrong yesterday.

This is in the Browser Console:

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data FormData.jsm:225:27

Which maps to this line in FormData.jsm:

    // Store the frame's current URL with its form data so that we can compare
    // it when restoring data to not inject form data into the wrong document.
    ret.url = getDocumentURI(doc);

    // We want to avoid saving data for about:sessionrestore as a string.
    // Since it's stored in the form as stringified JSON, stringifying further
    // causes an explosion of escape characters. cf. bug 467409
    if (isRestorationPage(ret.url)) {
      ret.id.sessionData = JSON.parse(ret.id.sessionData);  // <-- This line
    }

    return ret;

However, I also see that in non-e10s, so it might be a red herring.

Regardless, this is worth investigating.

	juan becerra [:juanb]
	Comment 4 • 9 years ago

I am unable to reproduce this on today's nightly on Windows or Mac. Following the steps in comment #0 the pages load fine, in both non-e10s and e10s mode.

Bogdan, do you still see this?

	Bogdan Maris, Desktop QA Reporter
	Comment 5 • 9 years ago

(In reply to juan becerra [:juanb] from comment #4)
> I am unable to reproduce this on today's nightly on Windows or Mac.
> Following the steps in comment #0 the pages load fine, in both non-e10s and
> e10s mode.
> 
> Bogdan, do you still see this?

I am not able to reproduce this issue anymore using latest Nightly (e10s and non-e10s) on Windows 7 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.9.5 but I`m still getting the same output in the Browser console as Mike in comment 3. 

Is this something we should worry about?

	Mike Conley (:mconley) (:⚙️)
	Comment 6 • 9 years ago

Not completely sure, to be honest. Clearly, we're having a hard time parsing a JSON string - it's likely not valid JSON.

smacleod - does this sound familiar or worrying?

	Steven MacLeod [:smacleod]
	Comment 7 • 9 years ago

Doesn't seem familiar to me - I'm going to defer to Tim though, he might have a better idea of what's happening.

	Tim Taubert [:ttaubert] (inactive)
	Comment 8 • 9 years ago

about:welcomeback is page that doesn't expect to be called like that and would need some fixing:

JavaScript error: chrome://browser/content/aboutSessionRestore.js, line 37: TypeError: document.getElementById(...) is null
JavaScript error: chrome://browser/content/aboutSessionRestore.js, line 68: TypeError: gStateObject is undefined

SessionStore detects a page that usually holds sessionstore data and doesn't expect it to be empty, or invalid JSON. We should probably fix that as well.

The page loads succeeds here. If it doesn't then I would be really surprised if that's connected to the errors in the console.

	Brad Lassey [:blassey] (use needinfo?)
	Comment 9 • 9 years ago

comment 3 says this is reproducible without e10s