Closed
Bug 1098433
Opened 10 years ago
Closed 10 years ago
Tabs tray on non-7" tablet looks crowded
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: antlam, Assigned: lucasr)
References
Details
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Is it me or do 5 items seem very crowded? I think we could either keep it consistent with the 7" (4 items) or tweak the padding a bit here. Not sure that we need to block V1 on this, but here's the bug.
Comment 2•10 years ago
|
||
Personally, I'd rather have fewer items per row with much larger screenshots suitable for a landscape tablet
Reporter | ||
Comment 3•10 years ago
|
||
I think 4 is our magic number here as a quick fix. BUT... That being said, I want to try and play with the padding on both sides here because it also seems awfully large here compared to the 7. We may find that after we do that, 5 might be OK. Thoughts?
Comment 4•10 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #2) > Personally, I'd rather have fewer items per row with much larger screenshots > suitable for a landscape tablet Just be careful with larger thumbnails. It takes more time and takes more memory.
Comment 5•10 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #4) > (In reply to Aaron Train [:aaronmt] from comment #2) > > Personally, I'd rather have fewer items per row with much larger screenshots > > suitable for a landscape tablet > > Just be careful with larger thumbnails. It takes more time and takes more > memory. I like to have nice things.
Assignee | ||
Updated•10 years ago
|
Reporter | ||
Comment 6•10 years ago
|
||
From the builds, I think 5 is still too congested and confusing. Looks extremely overwhelming when there are multiple rows. Let's go with 4 per row (horizontally).
Flags: needinfo?(lucasr.at.mozilla)
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8526165 [details] [diff] [review] Improve tabs panel grid padding on large tablets (r=mcomella) As per discussion with antlam.
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8526165 -
Flags: review?(michael.l.comella)
Updated•10 years ago
|
Assignee: nobody → lucasr.at.mozilla
Comment 9•10 years ago
|
||
Comment on attachment 8526165 [details] [diff] [review] Improve tabs panel grid padding on large tablets (r=mcomella) Review of attachment 8526165 [details] [diff] [review]: ----------------------------------------------------------------- If the antlam says okay, mcomella says okay.
Attachment #8526165 -
Flags: review?(michael.l.comella) → review+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46b9f69a642f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•