Closed Bug 1098556 Opened 10 years ago Closed 10 years ago

Rename locbar.pre.label to reflect new location bar preferences structure

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Iteration:
36.3

People

(Reporter: flod, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1098556 - Rename locbar.pre.label to reflect new location bar preferences structure. r=Unfocused
(deleted), text/x-review-board-request
Unfocused
: review+
Details
http://hg.mozilla.org/mozilla-central/diff/af22db534027/browser/locales/en-US/chrome/browser/preferences/privacy.dtd locbar.post.label has been removed, which makes sense since we now have checkboxes. But then you left locbar.pre.label, and that definitely doesn't work. Imagine this situation in English: locbar.pre.label = Suggest locbar.post.label = in the location bar when typing See what happens when you remove just the .post part? Even if English remains the same, locbar.pre.label needs to be renamed to force localizers to check and eventually updated existing translations.
Thanks, we overlooked that due to the en-US translation structure
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Keywords: regression
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Marco, please add this to the current iteration
Added to IT 36.3
Iteration: --- → 36.3
Summary: Rename locbar.pre.label to reflect new preferences tructure → Rename locbar.pre.label to reflect new location bar preferences structure
Attached file MozReview Request: bz://1098556/mak (obsolete) (deleted) —
Attachment #8523172 - Flags: review?(bmcbride)
/r/659 - Bug 1098556 - Rename locbar.pre.label to reflect new location bar preferences structure. r=Unfocused Pull down this commit: hg pull review -r c73b5f8944dc63817d8d5675780e2e4f59f2ca23
Attachment #8523172 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/integration/fx-team/rev/15e3285153be
Target Milestone: --- → Firefox 36
https://hg.mozilla.org/mozilla-central/rev/15e3285153be
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8523172 - Attachment is obsolete: true
Attachment #8618634 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: