Taken from bug 854982 see https://github.com/mozilla/addon-sdk/pull/1595/files

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ba96f4974adbf5e33751af6b3567ec062735197d Bug 1098946 - Expose "activate" and "deactivate" for windows & browsers. r=erikvold Conflicts: test/test-window-events.js https://github.com/mozilla/addon-sdk/commit/f1fed2c95c877d195f416c4f02517345f975255b Merge pull request #1714 from erikvold/1098946 Bug 1098946 - Expose "activate" and "deactivate" for sdk/window/events r=erikvold

I had to revert this in https://github.com/mozilla/addon-sdk/commit/7af31273bffb477d4a04846340aa6423b5042b48#diff-1

Only Linux was failing: TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-browser-events.test browser events | deactivate window - "deactivate" == "close" TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-browser-events.test browser events | other window deactivated TypeError: activate is undefined TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-browser-events.test browser events | Test timed out (after: window load) TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | deactivate window - "deactivate" == "close" TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | other window deactivated TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | activate event - "activate" == "deactivate" TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | target is window TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | undefined - "close" == "activate" TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-events.test dead object errors | window load TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-widget.testPanelWidget3 | Test timed out (after: onClick called on click for widget with both panel and onClick) TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testActiveWindow | Should not be any unexpected windows open Bug 873007 - Intermittent Jetpack tests/test-windows.testActiveWindow | Test output exceeded timeout (300s). TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testActiveWindow | Should not be any unexpected tabs open Bug 873007 - Intermittent Jetpack tests/test-windows.testActiveWindow | Test output exceeded timeout (300s).

From https://tbpl.mozilla.org/php/getParsedLog.php?id=52626960&tree=Jetpack&full=1 TEST-START | addon-sdk/tests/test-browser-events.test browser events TEST-PASS | addon-sdk/tests/test-browser-events.test browser events | undefined TEST-PASS | addon-sdk/tests/test-browser-events.test browser events | window ready TEST-PASS | addon-sdk/tests/test-browser-events.test browser events | undefined TEST-PASS | addon-sdk/tests/test-browser-events.test browser events | window load TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-browser-events.test browser events | deactivate window - "deactivate" == "close" TEST-INFO | Traceback (most recent call last): File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/chrome.js", line 34, in .observe.value emit(this, "data", { File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/core.js", line 97, in emit listener.apply(target, args); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 43, in transform/< on(input, "data", data => f(data, next)); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 60, in map/< const map = (input, f) => transform(input, (data, next) => next(f(data))); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 36, in transform/next const next = data => receive(output, data); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 115, in receive emit(input, "data", message); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/core.js", line 97, in emit listener.apply(target, args); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 84, in merge/forward/< on(input, "data", data => emit(output, "data", data)); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/core.js", line 97, in emit listener.apply(target, args); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 43, in transform/< on(input, "data", data => f(data, next)); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 53, in filter/< next(data); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 36, in transform/next const next = data => receive(output, data); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 115, in receive emit(input, "data", message); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/core.js", line 97, in emit listener.apply(target, args); File "resource://722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack/addon-sdk/tests/test-browser-events.js", line 37, in handler assert.equal(deactivate.type, "deactivate", "deactivate window") File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/test/assert.js", line 123, in equal this.fail({ File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail this._log.fail(message); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 98, in fail this.console.testMessage(false, false, this.test.name, message); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/test/harness.js", line 546, in testMessage this.trace(); TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-browser-events.test browser events | other window deactivated TEST-INFO | Traceback (most recent call last): File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/chrome.js", line 34, in .observe.value emit(this, "data", { File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/core.js", line 97, in emit listener.apply(target, args); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 43, in transform/< on(input, "data", data => f(data, next)); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 60, in map/< const map = (input, f) => transform(input, (data, next) => next(f(data))); File "resource://extensions.modules.722731bc-a80c-452f-be64-a34ab0335f10-at-jetpack.commonjs.path/sdk/event/utils.js", line 36, in transform/next const next = data => receive(output, data); ...

So we expect the order to be `[ ready, load, deactivate, activate, close ]` but only linux it appears to be `[ ready, load, close, deactivate, activate ]` So we could alter these tests to only ensure that activate comes after deactivate, and that the `[ ready, load, close ]` order is preserved?

At this point I think we should probably just assert that all of these events happen and do not assume an order.

Hey Irakli, I'm not sure if you want to work on this, if not could you please unassign yourself.

No time for this one atm.