Closed
Bug 1099474
Opened 10 years ago
Closed 4 years ago
Allow a root actor to not provide a tab list
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
INACTIVE
People
(Reporter: markh, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Fallen
:
feedback+
past
:
feedback+
|
Details | Diff | Splinter Review |
In bug 809561 comment 1:
(In reply to Philipp Kewisch [:Fallen] from bug 809561 comment #1)
> (or better yet, fix devtools to not require a tabList
> implementation).
It sounds like removing the requirement that a root supplies a tab list is desired, and it would greatly simplify my patch in that bug.
I'm attaching a patch that WFM:
* It changes the onListTabs() call to gracefully handle no tab list and still add all the other actors.
* It adds a bit of sugar to the "connect" page, hiding the tablist title when there are no tabs.
* It also includes a change to my patch in bug 809561 - obviously this shouldn't be part of this patch, but I'm including it for this feedback round for reference anyway.
Attachment #8523331 -
Flags: feedback?(philipp)
Attachment #8523331 -
Flags: feedback?(past)
Comment 1•10 years ago
|
||
Comment on attachment 8523331 [details] [diff] [review]
0002-Bug-XXXXXXXX-allow-root-actors-to-not-supply-a-tabLi.patch
Looks good from a Thunderbird perspective, f=philipp
Attachment #8523331 -
Flags: feedback?(philipp) → feedback+
Comment 2•10 years ago
|
||
Comment on attachment 8523331 [details] [diff] [review]
0002-Bug-XXXXXXXX-allow-root-actors-to-not-supply-a-tabLi.patch
Review of attachment 8523331 [details] [diff] [review]:
-----------------------------------------------------------------
I've been going back and forth on this for a while but I think that I'm sold on it now. We need to make sure all tests still pass of course.
Attachment #8523331 -
Flags: feedback?(past) → feedback+
Blocks: 1102326
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•