Closed
Bug 1100317
Opened 10 years ago
Closed 10 years ago
Gridview doesn't show the last row completely when more tabs open than will fit on a single screen
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 36
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Screenshot_2014-11-17-12-02-02.png
When the user has more tabs open than will fit on a single screen, the gridview cuts off the last row of tabs. We need to show the last row completely and display some padding at the bottom too.
|
||
Comment 1•10 years ago
|
||
This is because of this:
http://dxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/TabsPanel.java#246
The returned value should account for the toolbar height. mcomella hit the same issue with a different symptom in bug 1091587. He might already have a patch.
|
|
||
Updated•10 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8525965 -
Flags: review?(lucasr.at.mozilla)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8525965 [details] [diff] [review]
Gridview doesnt show the last row completely when more tabs open than will fit on a single screen
Review of attachment 8525965 [details] [diff] [review]:
-----------------------------------------------------------------
Yep.
Attachment #8525965 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Verified as fixed on latest Nightly on Nexus 7(Android 5.0) and Asus Transformer Pad TF300T(Android 4.1.1)
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•