+++ This bug was initially created as a clone of Bug #1090727 +++ the global/header template needs updating to support loading jquery. rough notes: - load both jquery and yui2 on every page by default - new header param "jqlibs" (or "jslibs"?) - initially support for jquery-ui only (loads smoothness css + js) - new header param "noyui" - so pages can opt out of loading yui2 - at some stage we need to invert this, so pages need to opt into yui2 - convert header, footer, and all dependent templates/js to jquery - required in order for pages to opt-out - yui hacks, such as onpagehide, can be removed if "noyui" is set - to simplify testing and reviewing avoid refactoring of code, a straight port is most useful

Comment on attachment 8523907 [details] [diff] [review] 1100382_1.patch Review of attachment 8523907 [details] [diff] [review]: ----------------------------------------------------------------- this doesn't work with no_yui=1 because the BMO extension's usermenu uses YUI, resulting in a js error when no_yui=1. for now it's ok to just disable the feature on no_yui=1 pages. i have to create a jquery-ui version for my show_bug prototypes, and i'll create a separate bug to migrate the usermenu to jquery once that's done.

+++ b/template/en/default/global/header.html.tmpl +[% style_urls.import(jquery_css, jq_css_urls) FILTER null %]

Comment on attachment 8526216 [details] [diff] [review] 1100382_3.patch Review of attachment 8526216 [details] [diff] [review]: ----------------------------------------------------------------- this looks good overall; the context menu plugin you found looks nice :) looks like t/008filter.t doesn't know about the 'null' filter.. t/008filter.t ........ 454/628 # Failed test '(en/default) template/en/default/global/header.html.tmpl has unfiltered directives: # 100: style_urls.import(jquery_css, jq_css_urls) FILTER null # --ERROR' # at t/008filter.t line 130. ::: extensions/BMO/web/js/edituser_menu.js @@ +36,5 @@ > + selector: ".vcard_" + id, > + trigger: "left", > + items: items > + }); > + // return false; nit: remove commented out line ::: js/jquery/plugins/contextMenu/contextMenu.css @@ +27,5 @@ > + -ms-box-shadow: 0 2px 5px rgba(0, 0, 0, 0.5); > + -o-box-shadow: 0 2px 5px rgba(0, 0, 0, 0.5); > + box-shadow: 0 2px 5px rgba(0, 0, 0, 0.5); > + font-family: Verdana, Arial, Helvetica, sans-serif; > + font-size: 11px; verdana is ugly; remove the font-family and size definitions so it uses the current skin's

Comment on attachment 8552499 [details] [diff] [review] 1100382_4.patch Review of attachment 8552499 [details] [diff] [review]: ----------------------------------------------------------------- r=glob

Thanks! To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git a496214..5cc88fd master -> master