Closed Bug 1100894 Opened 10 years ago Closed 10 years ago

Don't smooth scroll tab strip when restoring tabs on startup

Categories

(Firefox for Android Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(2 files)

We should simply move the tab strip to the proper position.
Priority: -- → P1
Attachment #8524526 - Flags: review?(michael.l.comella)
Attachment #8524527 - Flags: review?(michael.l.comella)
Comment on attachment 8524527 [details] [diff] [review] Don't smooth scroll when restoring tabs on startup (r=mcomella) Review of attachment 8524527 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tabs/TabStripView.java @@ +223,5 @@ > > private void ensurePositionIsVisible(final int position) { > + // We just want to move the strip to the right position > + // when restoring tabs on startup. > + if (isRestoringTabs) { I'd rather have this get passed as a parameter, but this looks like it works. The default methods, e.g. `refreshTabs()`, can call out to `refreshTabs(boolean isRestoringTabs)` with a default value to avoid a large amount of changes.
Attachment #8524527 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #3) > Comment on attachment 8524527 [details] [diff] [review] > Don't smooth scroll when restoring tabs on startup (r=mcomella) > > Review of attachment 8524527 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/base/tabs/TabStripView.java > @@ +223,5 @@ > > > > private void ensurePositionIsVisible(final int position) { > > + // We just want to move the strip to the right position > > + // when restoring tabs on startup. > > + if (isRestoringTabs) { > > I'd rather have this get passed as a parameter, but this looks like it works. > > The default methods, e.g. `refreshTabs()`, can call out to > `refreshTabs(boolean isRestoringTabs)` with a default value to avoid a large > amount of changes. Fair point but it ends up looking more complicated due to the all boolean passing between methods.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: