Closed Bug 1101190 Opened 10 years ago Closed 4 years ago

Remove new tablet edit_cancel button

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=java])

Don't need that.
What asset are you referring to here?
Flags: needinfo?(michael.l.comella)
https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/newtablet/res/layout-large-v11/new_tablet_browser_toolbar.xml?rev=75599db3d71d#100

The view with id=edit_cancel is defined in with visibility="gone" on new tablet because we use editCancel in BrowserToolbar - the reference should be moved to old tablet, and phone only. Note that the code change would be simplified if we wait until the old tablet code is removed, where just phone is needed (i.e. no code duplication).
Flags: needinfo?(michael.l.comella)
Ok, I'm moving this to v2 then.
Blocks: new-tablet-v2
No longer blocks: new-tablet-v1
Mentor: michael.l.comella, mhaigh
Whiteboard: [lang=java]
Might be taken care of as part of bug 1106935.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.