Closed
Bug 1101784
Opened 10 years ago
Closed 10 years ago
Don't clip to padding in tabs panel grid
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Otherwise the grid scrolls into 'nowhere'.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8525532 -
Flags: review?(michael.l.comella)
Comment 2•10 years ago
|
||
Comment on attachment 8525532 [details] [diff] [review] Don't clip to padding in tabs panel grid (r=mcomella) Review of attachment 8525532 [details] [diff] [review]: ----------------------------------------------------------------- Works, but this should probably be in styles.xml (Widget.TabsGridLayout [1]). (In reply to Lucas Rocha (:lucasr) from comment #0) > Otherwise the grid scrolls into 'nowhere'. What do you mean by this? The grid doesn't touch the bottom of the screen? [1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/styles.xml?rev=597441df1450#197
Attachment #8525532 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #2) > Comment on attachment 8525532 [details] [diff] [review] > Don't clip to padding in tabs panel grid (r=mcomella) > > Review of attachment 8525532 [details] [diff] [review]: > ----------------------------------------------------------------- > > Works, but this should probably be in styles.xml (Widget.TabsGridLayout [1]). Good point, done. > (In reply to Lucas Rocha (:lucasr) from comment #0) > > Otherwise the grid scrolls into 'nowhere'. > > What do you mean by this? The grid doesn't touch the bottom of the screen? Have a look at this: https://plus.google.com/+AndroidDevelopers/posts/LpAA7q4jw9M > [1]: > https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/ > values/styles.xml?rev=597441df1450#197
https://hg.mozilla.org/mozilla-central/rev/bcc4c4f72361
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•